From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EEA0C88E75 for ; Tue, 15 Sep 2026 08:53:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x6Ou5-00053I-C0; Tue, 15 Sep 2026 04:52:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6Otx-00052H-9n for qemu-devel@nongnu.org; Tue, 15 Sep 2026 04:52:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6Otv-0002iT-Pa for qemu-devel@nongnu.org; Tue, 15 Sep 2026 04:52:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789462347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nFubn8BDBuWlIA4SuFL9wQmEilcQ7anhQNncRhyPd8Y=; b=iKOIIcU3/C3+EZN0qf9jlYLm29zC09Dud3zenTAJi7ksUWd7R9/jwrUrEROovhJgMuo4h5 1eDqmaBBkNlzh9VdQMd9vQIqImY45OXsSOQlGwSdfcs6RIUhpuZ8DKq9+hTeTcWWvaWpXf LhONlWX3G8qZsR8xivxN/N7oaBKBsII= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-Z6bQ6UZ4Oh6YVGky5uVljA-1; Tue, 15 Sep 2026 04:52:23 -0400 X-MC-Unique: Z6bQ6UZ4Oh6YVGky5uVljA-1 X-Mimecast-MFC-AGG-ID: Z6bQ6UZ4Oh6YVGky5uVljA_1789462342 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6DD781956041; Tue, 15 Sep 2026 08:52:22 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4F904426; Tue, 15 Sep 2026 08:52:20 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Kyle Evans , Warner Losh , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Pierrick Bouvier Subject: [PATCH v2 2/5] meson: simplify clang version checks Date: Tue, 15 Sep 2026 09:52:10 +0100 Message-ID: <20260915085213.139944-3-berrange@redhat.com> In-Reply-To: <20260915085213.139944-1-berrange@redhat.com> References: <20260915085213.139944-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The checks for the clang minor versions are currently redundant since there can never be a minor version less than zero. Going forward it is likely sufficient to always pick a NN.0.0 release as the min CLang version, so drop the minor version checks. Acked-by: Marc-André Lureau Reviewed-by: Pierrick Bouvier Signed-off-by: Daniel P. Berrangé --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index cfac634cf1..cb3eaf3abe 100644 --- a/meson.build +++ b/meson.build @@ -330,11 +330,11 @@ foreach lang : all_languages # ok elif compiler.get_id() == 'clang' and compiler.compiles(''' #ifdef __apple_build_version__ - # if __clang_major__ < 15 || (__clang_major__ == 15 && __clang_minor__ < 0) + # if __clang_major__ < 15 # error You need at least XCode Clang v15.0 to compile QEMU # endif #else - # if __clang_major__ < 10 || (__clang_major__ == 10 && __clang_minor__ < 0) + # if __clang_major__ < 10 # error You need at least Clang v10.0 to compile QEMU # endif #endif''') -- 2.55.0