Re: [PATCH] staging: rtl8723bs: fix lines exceeding 100 columns in rtw_security.c

[kernel test robot <lkp@intel.com>]

Hi Rareș-Mihai,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Rare-Mihai-Vladu/staging-rtl8723bs-fix-lines-exceeding-100-columns-in-rtw_security-c/20260914-145256
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260914145256.996968-1-vladurares%40gmail.com
patch subject: [PATCH] staging: rtl8723bs: fix lines exceeding 100 columns in rtw_security.c
config: hexagon-randconfig-002-20260915 (https://download.01.org/0day-ci/archive/20260915/202609150940.PBljt2rP-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 148ee2b266b73a49f1f31d0bd17d4818b91bee9f)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260915/202609150940.PBljt2rP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609150940.PBljt2rP-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/staging/rtl8723bs/core/rtw_security.c:1337:7: error: redefinition of 'keyid' with a different type: 'int' vs 'u16' (aka 'unsigned short')
    1337 |                 int keyid = padapter->securitypriv.dot11wBIPKeyid;
         |                     ^
   drivers/staging/rtl8723bs/core/rtw_security.c:1311:7: note: previous definition is here
    1311 |                 u16 keyid = 0;
         |                     ^
   1 error generated.


vim +1337 drivers/staging/rtl8723bs/core/rtw_security.c

  1277	
  1278	u32 rtw_BIP_verify(struct adapter *padapter, u8 *precvframe)
  1279	{
  1280		struct rx_pkt_attrib *pattrib = &((union recv_frame *)precvframe)->u.hdr.attrib;
  1281		u8 *pframe;
  1282		u8 *BIP_AAD, *p;
  1283		u32 res = _FAIL;
  1284		uint len, ori_len;
  1285		struct ieee80211_hdr *pwlanhdr;
  1286		u8 mic[16];
  1287		struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
  1288		__le16 le_tmp;
  1289		__le64 le_tmp64 = 0;
  1290	
  1291		ori_len = pattrib->pkt_len - WLAN_HDR_A3_LEN + BIP_AAD_SIZE;
  1292		BIP_AAD = kzalloc(ori_len, GFP_KERNEL);
  1293		if (!BIP_AAD)
  1294			return _FAIL;
  1295	
  1296		/* PKT start */
  1297		pframe = (unsigned char *)((union recv_frame *)precvframe)->u.hdr.rx_data;
  1298		/* mapping to wlan header */
  1299		pwlanhdr = (struct ieee80211_hdr *)pframe;
  1300		/* save the frame body + MME */
  1301		memcpy(BIP_AAD + BIP_AAD_SIZE,
  1302		       pframe + WLAN_HDR_A3_LEN,
  1303		       pattrib->pkt_len - WLAN_HDR_A3_LEN);
  1304		/* find MME IE pointer */
  1305		p = rtw_get_ie(BIP_AAD + BIP_AAD_SIZE,
  1306			       WLAN_EID_MMIE,
  1307			       &len,
  1308			       pattrib->pkt_len - WLAN_HDR_A3_LEN);
  1309		/* Baron */
  1310		if (p) {
  1311			u16 keyid = 0;
  1312			u64 temp_ipn = 0;
  1313			/* save packet number */
  1314			memcpy(&le_tmp64, p + 4, 6);
  1315			temp_ipn = le64_to_cpu(le_tmp64);
  1316			/* BIP packet number should bigger than previous BIP packet */
  1317			if (temp_ipn <= pmlmeext->mgnt_80211w_IPN_rx)
  1318				goto BIP_exit;
  1319	
  1320			/* copy key index */
  1321			memcpy(&le_tmp, p + 2, 2);
  1322			keyid = le16_to_cpu(le_tmp);
  1323			if (keyid != padapter->securitypriv.dot11wBIPKeyid)
  1324				goto BIP_exit;
  1325	
  1326			/* clear the MIC field of MME to zero */
  1327			memset(p + 2 + len - 8, 0, 8);
  1328	
  1329			/* conscruct AAD, copy frame control field */
  1330			memcpy(BIP_AAD, &pwlanhdr->frame_control, 2);
  1331			ClearRetry(BIP_AAD);
  1332			ClearPwrMgt(BIP_AAD);
  1333			ClearMData(BIP_AAD);
  1334			/* conscruct AAD, copy address 1 to address 3 */
  1335			memcpy(BIP_AAD + 2, &pwlanhdr->addrs, sizeof(pwlanhdr->addrs));
  1336	
> 1337			int keyid = padapter->securitypriv.dot11wBIPKeyid;
  1338			u8 *bip_key = padapter->securitypriv.dot11wBIPKey[keyid].skey;
  1339	
  1340			if (omac1_aes_128(bip_key, BIP_AAD, ori_len, mic))
  1341				goto BIP_exit;
  1342	
  1343			/* MIC field should be last 8 bytes of packet (packet without FCS) */
  1344			if (!memcmp(mic, pframe + pattrib->pkt_len - 8, 8)) {
  1345				pmlmeext->mgnt_80211w_IPN_rx = temp_ipn;
  1346				res = _SUCCESS;
  1347			} else {
  1348			}
  1349	
  1350		} else {
  1351			res = RTW_RX_HANDLED;
  1352		}
  1353	BIP_exit:
  1354	
  1355		kfree(BIP_AAD);
  1356		return res;
  1357	}
  1358	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki