From: sashiko-bot@kernel.org
To: lty <781735889@qq.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: propagate errors from fast commit bitmap rebuild
Date: Tue, 15 Sep 2026 10:48:01 +0000 [thread overview]
Message-ID: <20260915104801.86F241F00899@smtp.kernel.org> (raw)
In-Reply-To: <tencent_B320F7091730E06C02BAB57D87B0CE363107@qq.com>
> ext4_fc_set_bitmaps_and_counters() rebuilds block bitmaps for modified
> inodes during fast-commit replay. When ext4_map_blocks() fails, the helper
> stops scanning but previously returned success. Errors from
> ext4_find_extent() were also discarded, so replay continued after an
> incomplete bitmap rebuild.
>
> Return errors from the helper and propagate them through both replay call
> sites so journal recovery aborts when bitmap reconstruction fails.
>
> Fixes: 8016e29f4362 ("ext4: fast commit recovery path")
> Cc: stable@vger.kernel.org
>
> Testing: With CONFIG_EXT4_DEBUG, QEMU fast-commit replay was run using a
> temporary fault injection that forced -EIO in the bitmap rebuild mapping
> call. The unmodified kernel reported recovery complete and mounted the
> filesystem; the patched kernel reported journal recovery failure and mount
> returned EIO. Built fs/ext4/fast_commit.o and a complete x86 bzImage.
>
> Signed-off-by: lty <781735889@qq.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_B320F7091730E06C02BAB57D87B0CE363107@qq.com?part=1
prev parent reply other threads:[~2026-09-15 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 10:29 [PATCH] ext4: propagate errors from fast commit bitmap rebuild lty
2026-09-15 10:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915104801.86F241F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=781735889@qq.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.