From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net V3 3/3] net/mlx5: LAG, reload IB reps of LAG master before the rest
Date: Tue, 15 Sep 2026 11:47:55 +0000 [thread overview]
Message-ID: <20260915114755.7B1361F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260915113459.3934760-4-tariqt@nvidia.com>
> From: Shay Drory <shayd@nvidia.com>
>
> In a shared-FDB LAG the master device creates the bond IB device; the
> other LAG members do not create their own, they populate a port inside
> the master's IB device. mlx5_lag_reload_ib_reps_unlocked() reloaded the
> members' IB reps in iteration order, with no guarantee the master is
> reloaded first. When a non-master member is reloaded before the master,
> it tries to populate its port in an IB device that has not been
> recreated yet.
>
> Hence, reload the master's IB reps first, then every other member.
>
> Fixes: 2b204cdb1206 ("net/mlx5: LAG, use xa_alloc to manage LAG device indices")
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Reviewed-by: Akiva Goldberger <agoldberger@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915113459.3934760-1-tariqt@nvidia.com?part=3
next prev parent reply other threads:[~2026-09-15 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 11:34 [PATCH net V3 0/3] net/mlx5: SD LAG and devcom stability fixes Tariq Toukan
2026-09-15 11:34 ` [PATCH net V3 1/3] net/mlx5: devcom, Base component size on linked devices Tariq Toukan
2026-09-15 11:47 ` sashiko-bot
2026-09-15 11:34 ` [PATCH net V3 2/3] net/mlx5: SD, unload reps on shared FDB create error path Tariq Toukan
2026-09-15 11:47 ` sashiko-bot
2026-09-15 11:34 ` [PATCH net V3 3/3] net/mlx5: LAG, reload IB reps of LAG master before the rest Tariq Toukan
2026-09-15 11:47 ` sashiko-bot [this message]
2026-09-18 1:00 ` [PATCH net V3 0/3] net/mlx5: SD LAG and devcom stability fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915114755.7B1361F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.