Re: [PATCH v2 08/13] leds: st1202: Take a reference on the LED firmware node

[sashiko-bot@kernel.org]

> st1202_dt_init() stores each LED's firmware node while walking the
> device tree with for_each_available_child_of_node_scoped(), which drops
> its reference to the node at the end of every iteration. The LED class
> stores the pointer with device_set_node() and does not take a reference
> of its own, so nothing keeps the node alive for as long as the LED
> device uses it. That has been the case since the driver was added, when
> the LED class devices were registered inside that same loop.
> 
> Commit c72e455b89f2 ("leds: leds-st1202: Fix NULL pointer access on race
> condition") moved the registration into a separate loop in
> st1202_probe(), which also leaves the stored pointer unreferenced
> between the two loops.
> 
> With CONFIG_OF_DYNAMIC the node can be freed while it is still in use,
> leaving led->fwnode and the LED device's firmware node dangling.
> 
> Take a reference when the node is stored and release it through a devm
> action. The action is registered before the LED class devices are, so it
> runs after they have been unregistered.
> 
> Fixes: 259230378c65 ("leds: Add LED1202 I2C driver")
> Signed-off-by: Manuel Fombuena <fombuena@outlook.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/GV1PR08MB8497668D389D43F680D2CE3CC5BA2@GV1PR08MB8497.eurprd08.prod.outlook.com?part=8