From: sashiko-bot@kernel.org
To: "Aldo Ariel Panzardo" <qwe.aldo@gmail.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v2] vsock: ignore empty child namespace mode writes
Date: Tue, 15 Sep 2026 14:22:12 +0000 [thread overview]
Message-ID: <20260915142213.57A431F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915141547.3010692-1-qwe.aldo@gmail.com>
> __vsock_net_mode_string() returns success without updating new_mode when
> the transfer length is zero. Its caller then reads the uninitialized enum
> and may permanently store a stack-derived value in the write-once child
> mode.
>
> Return before inspecting or storing new_mode when no bytes were
> transferred. This also prevents an empty write from locking the current
> mode.
>
> Fixes: eafb64f40ca4 ("vsock: add netns to vsock core")
> Cc: stable@vger.kernel.org
> Signed-off-by: Aldo Ariel Panzardo <qwe.aldo@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915141547.3010692-1-qwe.aldo@gmail.com?part=1
next prev parent reply other threads:[~2026-09-15 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 11:14 [PATCH] vsock: preserve child namespace mode on an empty write Aldo Ariel Panzardo
2026-09-15 11:21 ` sashiko-bot
2026-09-15 14:15 ` [PATCH v2] vsock: ignore empty child namespace mode writes Aldo Ariel Panzardo
2026-09-15 14:22 ` sashiko-bot [this message]
2026-09-15 16:32 ` Luigi Leonardi
2026-09-15 16:57 ` Stefano Garzarella
2026-09-15 16:50 ` Stefano Garzarella
2026-09-15 17:29 ` Aldo Ariel Panzardo
2026-09-15 17:30 ` [PATCH v3] " Aldo Ariel Panzardo
2026-09-15 17:39 ` sashiko-bot
2026-09-16 15:38 ` Stefano Garzarella
2026-09-16 16:53 ` Bobby Eshleman
2026-09-18 2:10 ` patchwork-bot+netdevbpf
2026-09-17 14:20 ` [PATCH] vsock: preserve child namespace mode on an empty write netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915142213.57A431F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=qwe.aldo@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.