From: sashiko-bot@kernel.org
To: "Nora Schiffer" <nora.schiffer@ew.tq-group.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, lee@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 5/8] leds: pca995x: Make output gain configurable
Date: Tue, 15 Sep 2026 14:22:49 +0000 [thread overview]
Message-ID: <20260915142250.3B3041F000FF@smtp.kernel.org> (raw)
In-Reply-To: <6b65d783052e84fd00c139a3b3f85b04f680b798.1789477502.git.nora.schiffer@ew.tq-group.com>
> The output gain linearly configures the LED current in 255 levels; the
> absolute current depends on both the gain value and the R_ext resistor
> connected to the LED driver. Make the gain configurable in the Device
> Tree instead of hardcoding it to 128, allowing to adjust the current
> for different hardware designs.
>
> Signed-off-by: Nora Schiffer <nora.schiffer@ew.tq-group.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/bd687915af26ccdbfc8cc911eee0787fc8145ae1.1789477502.git.nora.schiffer@ew.tq-group.com?part=5
next prev parent reply other threads:[~2026-09-15 14:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 13:43 [PATCH v2 1/8] dt-bindings: leds: pca995x: Describe reset-gpios property Nora Schiffer
2026-09-15 13:43 ` [PATCH v2 2/8] dt-bindings: leds: pca995x: Describe nxp,output-gain property Nora Schiffer
2026-09-15 14:22 ` sashiko-bot
2026-09-17 10:16 ` Krzysztof Kozlowski
2026-09-15 13:43 ` [PATCH v2 3/8] leds: pca995x: Fix maximum LED index for 16-channel variants Nora Schiffer
2026-09-15 14:24 ` sashiko-bot
2026-09-15 13:43 ` [PATCH v2 4/8] leds: pca995x: Add support for reset GPIO Nora Schiffer
2026-09-15 14:22 ` sashiko-bot
2026-09-15 13:43 ` [PATCH v2 5/8] leds: pca995x: Make output gain configurable Nora Schiffer
2026-09-15 14:22 ` sashiko-bot [this message]
2026-09-22 16:12 ` Lee Jones
2026-09-15 13:43 ` [PATCH v2 6/8] leds: pca995x: Add sysfs files for error reporting Nora Schiffer
2026-09-15 14:23 ` sashiko-bot
2026-09-15 13:43 ` [PATCH v2 7/8] leds: pca995x: Do not use full on LED mode Nora Schiffer
2026-09-15 14:26 ` sashiko-bot
2026-09-15 13:43 ` [PATCH v2 8/8] leds: pca995x: Add support for group brightness control Nora Schiffer
2026-09-15 14:32 ` sashiko-bot
2026-09-15 14:48 ` Nora Schiffer
2026-09-15 14:20 ` [PATCH v2 1/8] dt-bindings: leds: pca995x: Describe reset-gpios property sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915142250.3B3041F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nora.schiffer@ew.tq-group.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.