From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3B0DC982C1 for ; Tue, 15 Sep 2026 15:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qij4YbhqGrWEBbK7jYMYdG+4JdfJ6DF/DtBAAW0bgPc=; b=Dr8tJp4WrGlbrH 9UcM1/jhVZGFCmH6Sjzq/59Y++0njBT4rP/O6VKfMHE+iCs4yvi39NUN7ga6HvlG3B0EigS2lAbcV HmrmICeGfMdMGORt8ffaPF+gC0HXBtqcqR1acUcnts1wOR2G1IYzvWQXSswUbZ/+hJz4xxcsCaeDA VI7pEbzlmeBfWPMshS6zSrqQgWfNeVFQrxRP8HuCe1p9E8RWeV8NjNK+VV+IyGTsdY2hv5HuBIuVf 2bPO20cdaywpt2e89m+QnWCig+1ou5n4eP3Dim2J0Nra7fpHaZbIlD+drvgB0W+I+8RMtS24P7Tau 3/r9BAHsYmgtUApiv2DA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6VJ2-00000007GLZ-2fvb; Tue, 15 Sep 2026 15:42:48 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6VJ1-00000007GKw-1lSm for linux-phy@lists.infradead.org; Tue, 15 Sep 2026 15:42:47 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D84E4600C8; Tue, 15 Sep 2026 15:42:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F6931F00893; Tue, 15 Sep 2026 15:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789486966; bh=e8CA6A8+NEtvZVDKgf3JyCaOYgWoKmHI1CSRlYOsO9U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=m4AcCZ4eN0PJYC+6Kr7kdugxed4FtiCo+2MZR2ao2+V/K3jD/uQOz2YbShVwzBtnG kb8ceIGGiJrLDSgWcSrBDx+i+XOBtes+rTK56qKzLUcfOY/N4Yk2q1CdV+/mF2x+DR 9cx3gStlE8ZGuZBtt+730Upg4dV2aaSrmZoOwJ/0odxds0hvjgPkRpT1wtha8+/jc3 dMjwlEF5RIrzsO/kj7UIPQpySbf1l9c86TzYQO9zo1GeTOLRN5bCkc2TBjZ0y8uvnP vacuhVgtLIs+z+NVPFOa8i1c73FjjWzUbnp+loePtkTW1CJ4jvtBErEVtyp+WYj0XC UHkScHcGqvppg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 13/20] soc: starfive: Add jh7110-vout-subsystem driver To: "Michal Wilczynski" Cc: dri-devel@lists.freedesktop.org, robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, olteanv@gmail.com, mfd@lists.linux.dev, lee@kernel.org, vkoul@kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, linux-clk@vger.kernel.org In-Reply-To: <20260915-jh7110-clean-send-v4-13-f0e4fd6f2cc8@samsung.com> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-13-f0e4fd6f2cc8@samsung.com> Date: Tue, 15 Sep 2026 15:42:45 +0000 Message-Id: <20260915154246.1F6931F00893@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gc29jOiBzdGFyZml2 ZTogTm9DIGJ1cyBjbG9jayBsZWFrcyBwb3dlciBkdXJpbmcgc3lzdGVtIHNsZWVwCi0tCgpjb21t aXQgZjRiODhkMzgzMWRmOGRjMzBmYjQ0MmVkYjI0NDk5NjQzYzkyNGE1OApBdXRob3I6IE1pY2hh bCBXaWxjenluc2tpIDxtLndpbGN6eW5za2lAc2Ftc3VuZy5jb20+CnNvYzogc3RhcmZpdmU6IEFk ZCBqaDcxMTAtdm91dC1zdWJzeXN0ZW0gZHJpdmVyCgpUaGlzIGNvbW1pdCBhZGRzIGEgcGFyZW50 IGRyaXZlciBmb3IgdGhlIFN0YXJGaXZlIEpINzExMCB2aWRlbyBvdXRwdXQKc3Vic3lzdGVtLiBJ dCBjbGFpbXMgdGhlIE5vQyBkaXNwbGF5IGJ1cyBjbG9jayBhbmQgcmVzZXQsIGFuZCBob2xkcyBh IHJ1bnRpbWUKUE0gcmVmZXJlbmNlIHRvIGtlZXAgdGhlIFBEX1ZPVVQgcG93ZXIgZG9tYWluIGFj dGl2ZSBmb3IgYXMgbG9uZyBhcyBhbnkgY2hpbGQKZGV2aWNlIGV4aXN0cy4KCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvc29jL3N0YXJmaXZlL2poNzExMC12b3V0LXN1YnN5c3RlbS5jIGIvZHJpdmVy cy9zb2Mvc3RhcmZpdmUvamg3MTEwLXZvdXQtc3Vic3lzdGVtLmMKPiBuZXcgZmlsZSBtb2RlIDEw MDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLmFmNjMyNjkyZTIxMzkKPiAtLS0gL2Rldi9udWxs Cj4gKysrIGIvZHJpdmVycy9zb2Mvc3RhcmZpdmUvamg3MTEwLXZvdXQtc3Vic3lzdGVtLmMKClsg Li4uIF0KCj4gKwlidXNfY2xrID0gZGV2bV9jbGtfZ2V0X2VuYWJsZWQoZGV2LCBOVUxMKTsKPiAr CWlmIChJU19FUlIoYnVzX2NsaykpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCBQVFJf RVJSKGJ1c19jbGspLAo+ICsJCQkJICAgICAiRmFpbGVkIHRvIGVuYWJsZSBOb0MgYnVzIGNsb2Nr XG4iKTsKPiArCj4gKwlidXNfcnN0ID0gZGV2bV9yZXNldF9jb250cm9sX2dldF9leGNsdXNpdmVf ZGVhc3NlcnRlZChkZXYsIE5VTEwpOwoKW1NldmVyaXR5OiBNZWRpdW1dCkRvZXMgdGhpcyBjYXVz ZSBhIHBvd2VyIGxlYWsgZHVyaW5nIHN5c3RlbSBzdXNwZW5kPyBUaGUgTm9DIGJ1cyBjbG9jayBp cwplbmFibGVkIGhlcmUsIGJ1dCB0aGUgcG9pbnRlciB0byBidXNfY2xrIGlzIGRpc2NhcmRlZC4g VGhpcyBtZWFucyBpdCBjYW5ub3QKYmUgZGlzYWJsZWQgbGF0ZXIgZHVyaW5nIHN5c3RlbSBzbGVl cCB0cmFuc2l0aW9ucy4gCgpXaGlsZSB0aGUgZ2VucGQgZnJhbWV3b3JrIG1hbmFnZXMgdGhlIFBE X1ZPVVQgZG9tYWluIGR1cmluZyBzeXN0ZW0gc2xlZXAsIHRoZQpjbG9jayBmcmFtZXdvcmsgZG9l c24ndCBhdXRvbWF0aWNhbGx5IGRpc2FibGUgY2xvY2tzLiBUaGUgc29mdHdhcmUgZW5hYmxlCmNv dW50IHdpbGwgcmVtYWluIGdyZWF0ZXIgdGhhbiB6ZXJvLCB3aGljaCBjb3VsZCBrZWVwIHRoZSBO b0MgYnVzIGNsb2NrIGFuZAppdHMgcGFyZW50IFBMTHMgYWN0aXZlIGFuZCBsZWFrIHBvd2VyIGR1 cmluZyBzdXNwZW5kIChlLmcuLCBzdXNwZW5kLXRvLVJBTSkuCgpbIC4uLiBdCgo+ICtzdGF0aWMg c3RydWN0IHBsYXRmb3JtX2RyaXZlciBqaDcxMTBfdm91dF9zdWJzeXNfZHJpdmVyID0gewo+ICsJ LnByb2JlID0gamg3MTEwX3ZvdXRfc3Vic3lzX3Byb2JlLAo+ICsJLmRyaXZlciA9IHsKPiArCQku bmFtZSA9ICJqaDcxMTAtdm91dC1zdWJzeXN0ZW0iLAo+ICsJCS5vZl9tYXRjaF90YWJsZSA9IGpo NzExMF92b3V0X3N1YnN5c19vZl9tYXRjaCwKPiArCX0sCj4gK307Cj4gK21vZHVsZV9wbGF0Zm9y bV9kcml2ZXIoamg3MTEwX3ZvdXRfc3Vic3lzX2RyaXZlcik7CgpbU2V2ZXJpdHk6IE1lZGl1bV0K QmVjYXVzZSB0aGUgZHJpdmVyIHN0cnVjdCBsYWNrcyBhIC5wbSBmaWVsZCB3aXRoIHN5c3RlbSBz dXNwZW5kIGFuZCByZXN1bWUKY2FsbGJhY2tzLCBpdCBzZWVtcyB0aGVyZSBpcyBubyBtZWNoYW5p c20gdG8gZGlzYWJsZSB0aGUgTm9DIGJ1cyBjbG9jayB3aGVuCnRoZSBzeXN0ZW0gZ29lcyB0byBz bGVlcC4gU2hvdWxkIHRoZSBkcml2ZXIgc3RvcmUgdGhlIGNsb2NrIHBvaW50ZXIgaW4gYQpwcml2 YXRlIHN0cnVjdHVyZSBhbmQgaW1wbGVtZW50IGRldl9wbV9vcHMgY2FsbGJhY2tzIHRvIGhhbmRs ZSBkaXNhYmxpbmcKYW5kIHJlLWVuYWJsaW5nIHRoZSBjbG9jaz8KCi0tIApTYXNoaWtvIEFJIHJl dmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA5MTUtamg3MTEwLWNs ZWFuLXNlbmQtdjQtMC1mMGU0ZmQ2ZjJjYzhAc2Ftc3VuZy5jb20/cGFydD0xMwoKLS0gCmxpbnV4 LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105254A3F03; Tue, 15 Sep 2026 15:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789486968; cv=none; b=PwYyHiVDGfg7cD8a93embsCQcCJmAAQwChnKjwAeABhOshrkSV5dTKXr4jCgjtXuY6vjWsQejRk+n/13lPU+BLo6pQiBIkF3LcsR66sT8Cx+qUhpZRNwdmv2U3khVcgb5qVyub5DmByYqyJLCX2fFa0Hon6MIdASIaEnDLIk56E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789486968; c=relaxed/simple; bh=k25AYb4qZKIQDoiefNgb7MTlZ5VtWyh43e/+LbpZ2jQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=TJUBxsQCPJSD2vhfJp2t3B5WdZF/69tIaEw1c8bXhG0nLbccjTxRs9JKOKaXsRav9FXCgJ58POg6eULnWWCk6t0QXopjXYaCiQZBP9dZcIue50QozF6Zw6HlG+6BgH7tQpD3cOH3T/q2J5F3g4MJASh9x5WqSS5BY6TWEZpxBr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m4AcCZ4e; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m4AcCZ4e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F6931F00893; Tue, 15 Sep 2026 15:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789486966; bh=e8CA6A8+NEtvZVDKgf3JyCaOYgWoKmHI1CSRlYOsO9U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=m4AcCZ4eN0PJYC+6Kr7kdugxed4FtiCo+2MZR2ao2+V/K3jD/uQOz2YbShVwzBtnG kb8ceIGGiJrLDSgWcSrBDx+i+XOBtes+rTK56qKzLUcfOY/N4Yk2q1CdV+/mF2x+DR 9cx3gStlE8ZGuZBtt+730Upg4dV2aaSrmZoOwJ/0odxds0hvjgPkRpT1wtha8+/jc3 dMjwlEF5RIrzsO/kj7UIPQpySbf1l9c86TzYQO9zo1GeTOLRN5bCkc2TBjZ0y8uvnP vacuhVgtLIs+z+NVPFOa8i1c73FjjWzUbnp+loePtkTW1CJ4jvtBErEVtyp+WYj0XC UHkScHcGqvppg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 13/20] soc: starfive: Add jh7110-vout-subsystem driver Reply-To: sashiko-reviews@lists.linux.dev To: "Michal Wilczynski" Cc: dri-devel@lists.freedesktop.org, robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, olteanv@gmail.com, mfd@lists.linux.dev, lee@kernel.org, vkoul@kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, linux-clk@vger.kernel.org In-Reply-To: <20260915-jh7110-clean-send-v4-13-f0e4fd6f2cc8@samsung.com> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-13-f0e4fd6f2cc8@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Sep 2026 15:42:45 +0000 Message-Id: <20260915154246.1F6931F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] soc: starfive: NoC bus clock leaks power during system sleep -- commit f4b88d3831df8dc30fb442edb24499643c924a58 Author: Michal Wilczynski soc: starfive: Add jh7110-vout-subsystem driver This commit adds a parent driver for the StarFive JH7110 video output subsystem. It claims the NoC display bus clock and reset, and holds a runti= me PM reference to keep the PD_VOUT power domain active for as long as any chi= ld device exists. > diff --git a/drivers/soc/starfive/jh7110-vout-subsystem.c b/drivers/soc/s= tarfive/jh7110-vout-subsystem.c > new file mode 100644 > index 0000000000000..af632692e2139 > --- /dev/null > +++ b/drivers/soc/starfive/jh7110-vout-subsystem.c [ ... ] > + bus_clk =3D devm_clk_get_enabled(dev, NULL); > + if (IS_ERR(bus_clk)) > + return dev_err_probe(dev, PTR_ERR(bus_clk), > + "Failed to enable NoC bus clock\n"); > + > + bus_rst =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); [Severity: Medium] Does this cause a power leak during system suspend? The NoC bus clock is enabled here, but the pointer to bus_clk is discarded. This means it cannot be disabled later during system sleep transitions.=20 While the genpd framework manages the PD_VOUT domain during system sleep, t= he clock framework doesn't automatically disable clocks. The software enable count will remain greater than zero, which could keep the NoC bus clock and its parent PLLs active and leak power during suspend (e.g., suspend-to-RAM). [ ... ] > +static struct platform_driver jh7110_vout_subsys_driver =3D { > + .probe =3D jh7110_vout_subsys_probe, > + .driver =3D { > + .name =3D "jh7110-vout-subsystem", > + .of_match_table =3D jh7110_vout_subsys_of_match, > + }, > +}; > +module_platform_driver(jh7110_vout_subsys_driver); [Severity: Medium] Because the driver struct lacks a .pm field with system suspend and resume callbacks, it seems there is no mechanism to disable the NoC bus clock when the system goes to sleep. Should the driver store the clock pointer in a private structure and implement dev_pm_ops callbacks to handle disabling and re-enabling the clock? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260915-jh7110-cle= an-send-v4-0-f0e4fd6f2cc8@samsung.com?part=3D13