From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9C4E4A3F03; Tue, 15 Sep 2026 15:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789486985; cv=none; b=cqX2vOT2uiYufCV7pTp2oL8xwN/fufchPijfKwmUz5YkmXMLobWDW2Kt2vEg8adFSqa47JqUNR2on0su4FK1Y0jEWnatvzCNKtFg7JZKA3q090Gavm2dIHBgB64i38NgKsqDe7DYkrGnVdRbXGEhL9RVgcP4VgtPVrCiLCdBfBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789486985; c=relaxed/simple; bh=cdf5+rGDxhzMWd72yjv0Z6iqlsVPPWfAuPjsQpChQaU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=OxdvOfLWsFKJVu3SCAb/usegdF1AJMVubDp2zwb/bFpfLL5BeyGLvWIaIm8P6KTobY+fb03OfckrfgKsw8SBrD+IerCMPhB2xf949MtRpzPXvEwEPSJHTYRkZkMakHwdWbCiU/FmrM5eUB2HzkG+V0UN1SyaMANGU3YLhlEya28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FWoFG9h8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FWoFG9h8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F07CD1F000FF; Tue, 15 Sep 2026 15:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789486983; bh=/Q+TKB0dTqPeN8L0VQL0IxsQ2XnGw89/lImhUA0TRIc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FWoFG9h81W+EkeK6xWljLNGhi+4q24AllFDgLT9ezExiwRZj9G8qbHkRePJo+7VL+ YTbDGrwWdrikTHq6JsHf9EAERMMq6nazGfDxgx9UPbk/OvyJ7qaNpwon+330J+G67h UgU00QlM4ZwrbAjfZtwwpzsDAk3gSk+oS6dlx67YrMZDPLHs7eGby3nUIOhvtzsSmP mRyQ9RVjZ3tKQwrMLOQGQXpRqJgCRIDnrdDCJwy3Mx/TMJI6WPvuROLSRrnkatSeVW SEREuibAJD8pc607CF+dQ0o/8oPZJcpELssrY1oQYmI4/T/oeuCtmnpPRcsDRHl6Sq PG8Z8Do4o3nwg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 09/20] drm/bridge: inno-hdmi: Add .disable platform operation Reply-To: sashiko-reviews@lists.linux.dev To: "Michal Wilczynski" Cc: devicetree@vger.kernel.org, lee@kernel.org, dri-devel@lists.freedesktop.org, olteanv@gmail.com, robh@kernel.org, mfd@lists.linux.dev, linux-phy@lists.infradead.org, vkoul@kernel.org, linux-clk@vger.kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org In-Reply-To: <20260915-jh7110-clean-send-v4-9-f0e4fd6f2cc8@samsung.com> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-9-f0e4fd6f2cc8@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Sep 2026 15:43:02 +0000 Message-Id: <20260915154302.F07CD1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] drm/bridge: inno-hdmi: sleep in atomic context via .disable hook - [Medium] drm/bridge: inno-hdmi: hardware teardown LIFO ordering violation -- commit f7201b9edd5364bfbb0fe7f6dfc6706a0f43adf3 Author: Michal Wilczynski drm/bridge: inno-hdmi: Add .disable platform operation This commit introduces a new .disable platform operation to the Innosilicon HDMI driver and invokes it in inno_hdmi_bridge_atomic_disable(). It allows platform-specific drivers to implement power down sequences for PHYs and clocks. > diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/= inno-hdmi.c > index 1264152fb1434..06917e83c5e53 100644 > --- a/drivers/gpu/drm/bridge/inno-hdmi.c > +++ b/drivers/gpu/drm/bridge/inno-hdmi.c > @@ -886,6 +886,10 @@ static void inno_hdmi_bridge_atomic_disable(struct d= rm_bridge *bridge, > struct drm_atomic_commit *state) > { > struct inno_hdmi *hdmi =3D bridge_to_inno_hdmi(bridge); > + const struct inno_hdmi_plat_ops *plat_ops =3D hdmi->plat_data->ops; > + > + if (plat_ops && plat_ops->disable) > + plat_ops->disable(hdmi->dev); [Severity: High] Does this code introduce a sleep in atomic context? The inno_hdmi_bridge_atomic_disable() function runs from drm_atomic_helper_commit_tail(), which is an atomic context where sleeping = is strictly forbidden. However, the commit message mentions this hook is meant for calling phy_power_off() and clk_disable_unprepare(), which can sleep. [Severity: Medium] Will this break LIFO teardown ordering? Disabling the platform PHY and cloc= ks via plat_ops->disable() before calling inno_hdmi_standby() leaves the inter= nal HDMI controller configured while its underlying hardware is powered down. To maintain proper LIFO ordering, shouldn't inno_hdmi_standby() be called first to put the internal PHY registers in standby before disabling the platform clocks and PHY? > =20 > inno_hdmi_standby(hdmi); > } --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260915-jh7110-cle= an-send-v4-0-f0e4fd6f2cc8@samsung.com?part=3D9 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B675C88E7F for ; Tue, 15 Sep 2026 15:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TSLWRPQ/EOtl7ukaUMWqsL1BT5lShBFBBgKySlu/0C8=; b=GV4VvFxrj2mGad xu4auhns1k23lWIcrL/7PV5EnXkDlbm4y6HdDrX9LXsV2bJa6vQpUmO/je4bvsQMJ8J1HG1JU78Jb d6vhmgMHlAMbu4DohXV1uYU7V9QXJeDwzTwFNzDKwIs1IGRn/Vx25uh2Unz29SO9Y8+GdpHcgRhx8 ExO1iqtk27x8trpCtC7w2s7rvGE8IGtBUK391nP2NIWirVCxzwix2eZOu0PblIrUW4V4DkRF4r3t9 s1Brk1LyGwFHNr/llrWayTrqZy3678efMKJtQNN4zaJAhegOa/Ox7aZsW8i+6e7qX2eHgFHfMqgTw OtpxW1uRSpXXI3olw/gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6VJJ-00000007GNz-37Jw; Tue, 15 Sep 2026 15:43:05 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6VJI-00000007GNk-0deP for linux-phy@lists.infradead.org; Tue, 15 Sep 2026 15:43:04 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B573D40183; Tue, 15 Sep 2026 15:43:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F07CD1F000FF; Tue, 15 Sep 2026 15:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789486983; bh=/Q+TKB0dTqPeN8L0VQL0IxsQ2XnGw89/lImhUA0TRIc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FWoFG9h81W+EkeK6xWljLNGhi+4q24AllFDgLT9ezExiwRZj9G8qbHkRePJo+7VL+ YTbDGrwWdrikTHq6JsHf9EAERMMq6nazGfDxgx9UPbk/OvyJ7qaNpwon+330J+G67h UgU00QlM4ZwrbAjfZtwwpzsDAk3gSk+oS6dlx67YrMZDPLHs7eGby3nUIOhvtzsSmP mRyQ9RVjZ3tKQwrMLOQGQXpRqJgCRIDnrdDCJwy3Mx/TMJI6WPvuROLSRrnkatSeVW SEREuibAJD8pc607CF+dQ0o/8oPZJcpELssrY1oQYmI4/T/oeuCtmnpPRcsDRHl6Sq PG8Z8Do4o3nwg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 09/20] drm/bridge: inno-hdmi: Add .disable platform operation To: "Michal Wilczynski" Cc: devicetree@vger.kernel.org, lee@kernel.org, dri-devel@lists.freedesktop.org, olteanv@gmail.com, robh@kernel.org, mfd@lists.linux.dev, linux-phy@lists.infradead.org, vkoul@kernel.org, linux-clk@vger.kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org In-Reply-To: <20260915-jh7110-clean-send-v4-9-f0e4fd6f2cc8@samsung.com> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-9-f0e4fd6f2cc8@samsung.com> Date: Tue, 15 Sep 2026 15:43:02 +0000 Message-Id: <20260915154302.F07CD1F000FF@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGRybS9icmlkZ2U6IGlu bm8taGRtaTogc2xlZXAgaW4gYXRvbWljIGNvbnRleHQgdmlhIC5kaXNhYmxlIGhvb2sKLSBbTWVk aXVtXSBkcm0vYnJpZGdlOiBpbm5vLWhkbWk6IGhhcmR3YXJlIHRlYXJkb3duIExJRk8gb3JkZXJp bmcgdmlvbGF0aW9uCi0tCgpjb21taXQgZjcyMDFiOWVkZDUzNjRiZmJiMGZlN2Y2ZGZjNjcwNmEw ZjQzYWRmMwpBdXRob3I6IE1pY2hhbCBXaWxjenluc2tpIDxtLndpbGN6eW5za2lAc2Ftc3VuZy5j b20+Cgpkcm0vYnJpZGdlOiBpbm5vLWhkbWk6IEFkZCAuZGlzYWJsZSBwbGF0Zm9ybSBvcGVyYXRp b24KClRoaXMgY29tbWl0IGludHJvZHVjZXMgYSBuZXcgLmRpc2FibGUgcGxhdGZvcm0gb3BlcmF0 aW9uIHRvIHRoZSBJbm5vc2lsaWNvbgpIRE1JIGRyaXZlciBhbmQgaW52b2tlcyBpdCBpbiBpbm5v X2hkbWlfYnJpZGdlX2F0b21pY19kaXNhYmxlKCkuIEl0IGFsbG93cwpwbGF0Zm9ybS1zcGVjaWZp YyBkcml2ZXJzIHRvIGltcGxlbWVudCBwb3dlciBkb3duIHNlcXVlbmNlcyBmb3IgUEhZcyBhbmQK Y2xvY2tzLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9pbm5vLWhkbWku YyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvaW5uby1oZG1pLmMKPiBpbmRleCAxMjY0MTUyZmIx NDM0Li4wNjkxN2U4M2M1ZTUzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv aW5uby1oZG1pLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2lubm8taGRtaS5jCj4g QEAgLTg4Niw2ICs4ODYsMTAgQEAgc3RhdGljIHZvaWQgaW5ub19oZG1pX2JyaWRnZV9hdG9taWNf ZGlzYWJsZShzdHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlLAo+ICAJCQkJCSAgICBzdHJ1Y3QgZHJt X2F0b21pY19jb21taXQgKnN0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgaW5ub19oZG1pICpoZG1pID0g YnJpZGdlX3RvX2lubm9faGRtaShicmlkZ2UpOwo+ICsJY29uc3Qgc3RydWN0IGlubm9faGRtaV9w bGF0X29wcyAqcGxhdF9vcHMgPSBoZG1pLT5wbGF0X2RhdGEtPm9wczsKPiArCj4gKwlpZiAocGxh dF9vcHMgJiYgcGxhdF9vcHMtPmRpc2FibGUpCj4gKwkJcGxhdF9vcHMtPmRpc2FibGUoaGRtaS0+ ZGV2KTsKCltTZXZlcml0eTogSGlnaF0KRG9lcyB0aGlzIGNvZGUgaW50cm9kdWNlIGEgc2xlZXAg aW4gYXRvbWljIGNvbnRleHQ/IFRoZQppbm5vX2hkbWlfYnJpZGdlX2F0b21pY19kaXNhYmxlKCkg ZnVuY3Rpb24gcnVucyBmcm9tCmRybV9hdG9taWNfaGVscGVyX2NvbW1pdF90YWlsKCksIHdoaWNo IGlzIGFuIGF0b21pYyBjb250ZXh0IHdoZXJlIHNsZWVwaW5nIGlzCnN0cmljdGx5IGZvcmJpZGRl bi4gSG93ZXZlciwgdGhlIGNvbW1pdCBtZXNzYWdlIG1lbnRpb25zIHRoaXMgaG9vayBpcyBtZWFu dApmb3IgY2FsbGluZyBwaHlfcG93ZXJfb2ZmKCkgYW5kIGNsa19kaXNhYmxlX3VucHJlcGFyZSgp LCB3aGljaCBjYW4gc2xlZXAuCgpbU2V2ZXJpdHk6IE1lZGl1bV0KV2lsbCB0aGlzIGJyZWFrIExJ Rk8gdGVhcmRvd24gb3JkZXJpbmc/IERpc2FibGluZyB0aGUgcGxhdGZvcm0gUEhZIGFuZCBjbG9j a3MKdmlhIHBsYXRfb3BzLT5kaXNhYmxlKCkgYmVmb3JlIGNhbGxpbmcgaW5ub19oZG1pX3N0YW5k YnkoKSBsZWF2ZXMgdGhlIGludGVybmFsCkhETUkgY29udHJvbGxlciBjb25maWd1cmVkIHdoaWxl IGl0cyB1bmRlcmx5aW5nIGhhcmR3YXJlIGlzIHBvd2VyZWQgZG93bi4gVG8KbWFpbnRhaW4gcHJv cGVyIExJRk8gb3JkZXJpbmcsIHNob3VsZG4ndCBpbm5vX2hkbWlfc3RhbmRieSgpIGJlIGNhbGxl ZCBmaXJzdAp0byBwdXQgdGhlIGludGVybmFsIFBIWSByZWdpc3RlcnMgaW4gc3RhbmRieSBiZWZv cmUgZGlzYWJsaW5nIHRoZSBwbGF0Zm9ybQpjbG9ja3MgYW5kIFBIWT8KCj4gIAo+ICAJaW5ub19o ZG1pX3N0YW5kYnkoaGRtaSk7Cj4gIH0KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczov L3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA5MTUtamg3MTEwLWNsZWFuLXNlbmQtdjQtMC1m MGU0ZmQ2ZjJjYzhAc2Ftc3VuZy5jb20/cGFydD05CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlz dApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK