From: sashiko-bot@kernel.org
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: qcom-geni: avoid unused-function warning
Date: Tue, 15 Sep 2026 20:20:27 +0000 [thread overview]
Message-ID: <20260915202027.835BF1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260915200435.3524505-1-arnd@kernel.org>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The qcom_geni_serial_poll_rx_fifo_locked() function is only
> used for console support, but defined outside of the #ifdef block:
>
> drivers/tty/serial/qcom_geni_serial.c:918:13: error: 'qcom_geni_serial_poll_rx_fifo_locked' defined but not used [-Werror=unused-function]
> 918 | static void qcom_geni_serial_poll_rx_fifo_locked(struct uart_port *uport)
>
> Move the function definition to a more appropriate place that
> avoids the warning.
>
> Fixes: 8200871327d1 ("serial: qcom-geni: Keep FIFO RX active during console TX")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915200435.3524505-1-arnd@kernel.org?part=1
next prev parent reply other threads:[~2026-09-15 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 20:04 [PATCH] serial: qcom-geni: avoid unused-function warning Arnd Bergmann
2026-09-15 20:20 ` sashiko-bot [this message]
2026-09-23 12:48 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915202027.835BF1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=arnd@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.