From: sashiko-bot@kernel.org
To: "Francesco Valla" <francesco@valla.it>
Cc: "Eugenio Perez" <eperezma@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux.dev
Subject: Re: [PATCH 2/2] spi: virtio: drop unused field from private data
Date: Tue, 15 Sep 2026 20:52:32 +0000 [thread overview]
Message-ID: <20260915205232.97DD61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915-virtio-spi-fix2-v1-2-7a474cb1b13b@valla.it>
> The mode_func_supported field is read from the config space into the
> driver's private data, but then never used outside of the function it is
> read in. Drop the variable from the private data and parse it from the
> stack instead.
>
> Signed-off-by: Francesco Valla <francesco@valla.it>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-virtio-spi-fix2-v1-0-7a474cb1b13b@valla.it?part=2
next prev parent reply other threads:[~2026-09-15 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 20:24 [PATCH 0/2] spi: virtio: fix max frequency setting plus minor cleanup Francesco Valla
2026-09-15 20:24 ` [PATCH 1/2] spi: virtio: fix max frequency setting Francesco Valla
2026-09-15 20:51 ` sashiko-bot
2026-09-15 20:24 ` [PATCH 2/2] spi: virtio: drop unused field from private data Francesco Valla
2026-09-15 20:52 ` sashiko-bot [this message]
2026-09-17 14:54 ` [PATCH 0/2] spi: virtio: fix max frequency setting plus minor cleanup Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915205232.97DD61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=francesco@valla.it \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.