From: sashiko-bot@kernel.org
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] selinux: avoid 64-bit division of inode numbers
Date: Tue, 15 Sep 2026 21:44:29 +0000 [thread overview]
Message-ID: <20260915214429.CCEDB1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915213807.481355-2-paul@paul-moore.com>
> As reported by Arnd, a previous change to convert the selinuxfs inode
> numbers to u64 to match the rest of the kernel caused a problem on 32-bit
> systems:
>
> arm-linux-gnueabi-ld: .../selinuxfs.o: in function `sel_read_class':
> selinuxfs.c:(.text+0xdcc): undefined reference to `__aeabi_uldivmod'
> arm-linux-gnueabi-ld: .../selinuxfs.o: in function `sel_read_perm':
> selinuxfs.c:(.text+0xed0): undefined reference to `__aeabi_uldivmod'
>
> Since we don't currently use more than 24-bits in the selinuxfs inodes
> (see SEL_INO_MASK), fix this by applying the SEL_INO_MASK to the
> selinuxfs inode numbers and casting to a u32 before performing any
> division operations.
>
> Fixes: fc68b6a45f16 ("selinux: convert selinuxfs inode numbers from unsigned long to u64")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Paul Moore <paul@paul-moore.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915213807.481355-2-paul@paul-moore.com?part=1
next prev parent reply other threads:[~2026-09-15 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 21:38 [PATCH] selinux: avoid 64-bit division of inode numbers Paul Moore
2026-09-15 21:44 ` sashiko-bot [this message]
2026-09-16 3:32 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915214429.CCEDB1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.