All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lasse Collin <lasse.collin@tukaani.org>
To: Matt Turner <mattst88@gmail.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Magnus Lindholm <linmag7@gmail.com>,
	Nick Terrell <terrelln@fb.com>, David Sterba <dsterba@suse.com>,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org
Subject: Re: [PATCH 1/3] xz: add arch-specific tuning for alpha
Date: Tue, 15 Sep 2026 22:03:01 +0300	[thread overview]
Message-ID: <20260915220301.64f72f3f.lasse.collin@tukaani.org> (raw)
In-Reply-To: <20260912-alpha-kernel-compression-v1-1-ce9d55330193@gmail.com>

On 2026-09-12 Matt Turner wrote:
> Alpha has fixed-length, 4-byte-aligned instructions and no XZ BCJ
> filter, so it wants the same LZMA2 settings as the other
> 4-byte-aligned targets. Without an entry it hits the default case,
> which warns
> 
>   scripts/xz_wrap.sh: Arch-specific tuning is missing for 'alpha'
> 
> and conservatively assumes 2-byte alignment. Alpha gains
> HAVE_KERNEL_XZ later in this series; the correct alignment also
> shrinks a UP1500 kernel's XZ image from 6469320 to 6448840 bytes.
> 
> Signed-off-by: Matt Turner <mattst88@gmail.com>
> ---
>  scripts/xz_wrap.sh | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/xz_wrap.sh b/scripts/xz_wrap.sh
> index f19369687030..5af0d9045cbc 100755
> --- a/scripts/xz_wrap.sh
> +++ b/scripts/xz_wrap.sh
> @@ -10,6 +10,7 @@
>  # XZ-compressed kernel isn't currently supported on every listed arch.
>  #   Arch        Align   Notes
> +#   alpha         4
>  #   arm          2/4    ARM and ARM-Thumb2
>  #   arm64         4
>  #   csky          2
> @@ -44,6 +45,10 @@ BCJ=
>  # Set the BCJ filter if one is available.
>  # It must match the #ifdef usage in lib/decompress_unxz.c.
>  case $SRCARCH in
> +	alpha)
> +		ALIGN=4
> +		;;
> +
>  	arm)
>  		if is_enabled CONFIG_THUMB2_KERNEL; then
>  			ALIGN=2
> 

Thanks for Cc'ing me. For this patch:

Reviewed-by: Lasse Collin <lasse.collin@tukaani.org>

I looked at the other patches too and didn't see any issues around the
decompressor usage, but I didn't really review them.

-- 
Lasse Collin

  parent reply	other threads:[~2026-09-15 19:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12 19:55 [PATCH 0/3] alpha: self-extracting compressed kernel images Matt Turner
2026-09-12 19:55 ` [PATCH 1/3] xz: add arch-specific tuning for alpha Matt Turner
2026-09-13  9:45   ` Magnus Lindholm
2026-09-15 19:03   ` Lasse Collin [this message]
2026-09-17 17:54     ` Magnus Lindholm
2026-09-12 19:55 ` [PATCH 2/3] alpha: add self-extracting compressed kernel boot stub Matt Turner
2026-09-13  9:47   ` Magnus Lindholm
2026-09-12 19:55 ` [PATCH 3/3] alpha: support the remaining kernel compression formats Matt Turner
2026-09-13  9:56   ` Magnus Lindholm
2026-09-13  9:57 ` [PATCH 0/3] alpha: self-extracting compressed kernel images Magnus Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915220301.64f72f3f.lasse.collin@tukaani.org \
    --to=lasse.collin@tukaani.org \
    --cc=dsterba@suse.com \
    --cc=linmag7@gmail.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.