From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A77A3ACEE0 for ; Tue, 15 Sep 2026 22:31:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789511508; cv=none; b=ojfxQmQIaLA4VWRv15kcdWDBPdfOkxc5gULIQFhfeXPECrpPrZnEzTx9DBNgFO3OX8r94IO6vdwmU6Q59l3D9yMDdTA3lK9C4DZ+BPanvEDq9nDogD/NSdslOnYJx+xjqFOP2pk9kV15P+VIklsHOHP9qUF2s8oR8/ujl79tIho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789511508; c=relaxed/simple; bh=a2CRC0suMp5REApEy8/qcsXbL30zSop8JFr3EtNrZjk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kOzetsKQT7LpNfMvwBaFYX8YQLCe1v5dB/iQO6jVFdAqF00xdK68YeeEq2+QcdJIlLHvNXcszNbbOyVYrL2lZ2w7TdB99n2qkg6wBjbiTnX7C4N4XKExGTGCGobG/z1s2i+f4tcZ/nMEYMnvnkPCWJCo410c7VbUj4viG3ti7HM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d18diZVD; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d18diZVD" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccb1a98dso219911a91.0 for ; Tue, 15 Sep 2026 15:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789511506; x=1790116306; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=UCjk7rkFTyN2WMYlt7IlI6BX3j091q/yk2Leouece6E=; b=d18diZVDu3zBfyDsv11X0qvCm/KRttkDeNNbjRSwAJy5BQW32dtQ+8eN5G7D5LbP0+ escZSextj1qlTkVXvX1CWBWczZk2X7aEt5eAn4amT1hVPSK5R7qVvzSeR/nixssdfCLB Q8Dvyn2bF1femPWtyee9Bc9vVBRWCp8SJs7uQL9TxfxUoYu7m5Crzh98l/6Smt1Wki3M pcnTaVIJs0I+L2NvboeQsQWmrNcuTMLfF21/RfQdEu6qbVBXZ70p/jBRo2OPASMqhDQj Gc8TK9oYc7osCmcpniuiuh0qXldP937Y0aDRSLnbpZH8rFgtqPHEhUT7U9JWJeKTyiP3 pLhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789511506; x=1790116306; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UCjk7rkFTyN2WMYlt7IlI6BX3j091q/yk2Leouece6E=; b=CAs9Imca7CBXBbhvq5C6LX1TSMIcBypH/RJkhjSN8nsrOQcALBSxonKIwXammHVuMU d+Luw9oPimeIwIS/qXyRojXFdQust3KOXXmKKLQfYdiyMcH5mzIp6mo8zXvE18uAa1iZ vi2GNhjGrXIIJ0S64ZHV6GTv1gWl5LU0MIfOe6ZExrwV5SmZnZFFrJpU0XlPXMRNQv6T mv57t36erPMH/kjzeNn1Q30v39yYRYAzeZm6u5yVEkrvr0N4M8s+bnjZsm2Lr7QJY5Au k7N4CA0QtC/jUvFYPyDJ7x9GMO7ND5/9uHyfs9qUsFUxEidEecoHYDg8TEQcRlI/thAS nrzw== X-Forwarded-Encrypted: i=1; AKwUvBxOryW/KZGH+AYzDlTNvJxWtzbHf9ZdpeTahbH9zzWcw6F29MHu0wwSIJ92y35Q0uEbkIASk1s=@vger.kernel.org X-Gm-Message-State: AFuF++la1X2qyIvXGtBDdPdbrHuy1TxUJTaN6ZUaUEoYG4rGvr8qE350 6rZriGsKB0+jfKtwh38AYVZiYw2ugJw389wcTjDNqAEJcuP6i93vZfg= X-Gm-Gg: AYBFou3vSBstU6NX685Za7Nanyg5t8zyj61zZf+sDO1BvUSsnuI07plXSB7EPGOCWJo mv/55UNIruf9Vc8/pZmJBsqljjT+D26BCJJecBzthAwRKvpCak6mYcTAPwX6cLu4WF41khyvNVt vDhBQwsLeehnSA9a9nSGqamtX4Y/lDJg4pAykWJw0bKqThlFJDT5XO1AKjqJs6i64IlDHyJEe4r SO76ZRvxaTSIwRuWd1kS3c5ifHi9kSUeXrMi9NFpeHFxOdMmMNZ+V/mW+YSW1S/0IhqVrmcNjTH ZRwTfisIFR4hcKI2tkGLjh6P4uQvzOZtC8AIrz8WYgnaO8CmvgaGWsd13ufWro7Qdq7qthDfGc8 M6QN38Lb0cBb8AfExDklG5IoQlaASegWNdSjpa5s8VFscmsJVi/8B5p6Q41zPNboEu3cLX/+pq4 HG3hOuQlc39zzyf5Mwa4nirwlqicz4+trlRnEMyaET1XTaeGwkhVJLu0PrSkDtUzZqV09VxznJo hN4/HjVbdSwaHdlZPG+4W53lw== X-Received: by 2002:a17:90b:2e83:b0:39d:f61d:4b93 with SMTP id 98e67ed59e1d1-39e1e441e9amr779736a91.13.1789511506341; Tue, 15 Sep 2026 15:31:46 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([2001:2d8:7f00:8c85:556:537c:f7cd:8a1b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e1c337e97sm208036a91.2.2026.09.15.15.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 15:31:45 -0700 (PDT) From: Donggeun Yoo To: Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Russell King , Daniel Golle , Rosen Penev , Christian Marangi , Sashiko , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Donggeun Yoo Subject: [PATCH net v3 0/2] net: phy: qca808x: fix the active-high LED polarity mode Date: Wed, 16 Sep 2026 07:31:36 +0900 Message-ID: <20260915223138.321307-1-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A QCA8081 with an 'active-high' LED node does not work today, in two separate ways, so this is now two patches: qca808x_led_polarity_set() rejects the mode outright, and once it stops doing that qca808x_config_init() still will not put the bit back after the reset phy_init_hw() runs. Tested in QEMU against a synthetic MDIO bus that answers as a QCA8081 and emulates MMD7 0x901a, with the reset clearing BIT(6) as f203c8c77c76 describes. One kernel, one harness, three arms, x86_64, 7.3.0-rc2+: DT node base 1/2 only 1/2 + 2/2 active-high -EINVAL inverted correct active-low correct correct correct no polarity node correct correct correct high-impedance -EINVAL -EINVAL -EINVAL Still no QCA808x hardware here; the harness emulates the one register, so a confirmation on a real board would be welcome. Changes since v2: https://lore.kernel.org/netdev/20260914214720.2467586-1-donggeunyoo.kernel@gmail.com/ - Split in two, one defect each, per Christian Marangi. - Add QCA808X_PHY_LED_UNSET and express the condition as PHY_LED_ACTIVE_LOW instead of bare -1/0/1, per Christian Marangi. - Tested rather than compile-tested; see the table above. Donggeun Yoo (2): net: phy: qca808x: accept the active-high LED polarity mode net: phy: qca808x: keep an explicit active-high LED across the reset drivers/net/phy/qcom/qca808x.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) -- 2.53.0