From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6DB9C88E7D for ; Wed, 16 Sep 2026 05:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0uEKxahRyi+OLn+C//hdXAFcJKQaUJ4E7tV7IKAJQEs=; b=AjW9nTgV9IEeyKKvLfQuk3ZEwz ygJuHOFSbHwgjaXkshNyTXS3Nyw5OBH+xew3sAOvPB0FQG5YDMtzbFpvg/OKhbWpsI3oCbZStpMHJ pM0I2XUzA1XrKvpVFJKhQ1D7vsG5KHaYO16fJrxVZ7z6dV7nPbGOcApzZd06t7pyPzceRK6jXggwI ZeV3siBLxGmf2uwAoDaL+7WwaLAucL76rAcRQFF4cb1A0DzMZKkbC5XnXJaUVUypcS4rycf60tSpm OhuO+eMOhogV7RiE31jPisCCBcYNFk7lCviirNA+3bH0buwO2tLieAMBjkDI0tznLLZw2qC3HlV2g ll6wwd1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6hli-00000008LJu-3aee; Wed, 16 Sep 2026 05:01:14 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6hlZ-00000008LFm-0E8A for linux-arm-kernel@bombadil.infradead.org; Wed, 16 Sep 2026 05:01:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=0uEKxahRyi+OLn+C//hdXAFcJKQaUJ4E7tV7IKAJQEs=; b=Lnze0d7RMPSh1ADncv+QCyQEmY QXKZ+TttSQiSjisbcxATrkP2Nv4WMbf51fbGe/kB4D4DJGGxe/q36nUlzkuY2rsrD1OT6uCZX8ytG XV/i2xPZdMZBkqPOg7Ugqp7FBieJy2Ert81T4FdhDHqZr80gVXja5xhE2AhFbJ/MGR+dRF2Au4ZdP XIj+NcUNYQblGDTDW4tYtuz/D90cF62Ilb+YwjDOrzfaDdXXWIjX2PIMZc2YraIEuj+9ijlwvU5Bs JeYOz5aHkiGvf5qiyVIzThsuE+9lbm3UojRAECc90o354PI4TSlxynZx8y7W679B79odLBsVKJq6N Aw6d5qAg==; Received: from mail-pz2-x10.google.com ([2607:f8b0:4864:3b::10]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x6hlV-00000007UJf-2e9C for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2026 05:01:03 +0000 Received: by mail-pz2-x10.google.com with SMTP id 41be03b00d2f7-cc1cea50dc0so227912a12.2 for ; Tue, 15 Sep 2026 22:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534860; x=1790139660; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0uEKxahRyi+OLn+C//hdXAFcJKQaUJ4E7tV7IKAJQEs=; b=LXLV4CwYMNzsbv4+SLoTp7dxmkgV+B4mMl/OXE7d87zsgMjPr5B4dauCi+r5GaTsj8 RELNI3AcVsCmuRwnsV1uuIn1Te03R5KepxFy1g59Lhl2cEA2BVemTl+EbVOyCQSzJvE2 hduEfDyWl0PPpH4oDTHOPHN0+eBSIa84JPJUFhUubhDbzN9YHCMeTcP5zMpVyT18B892 ALmAe0MwcBLMYAb8Z65KVQ1BLAoXQUSRaUGk5qzaKMTF5sPr7D89gu4Mv4ur/5SmwKVi VulT+rAkE9ESeBO3MlrzG6Cnzt/H7u379GnhoYaGelLRbVcc7XcBhl8jQxILJuxKjqbk o1+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534860; x=1790139660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0uEKxahRyi+OLn+C//hdXAFcJKQaUJ4E7tV7IKAJQEs=; b=BqXad8RqIXFznod+Tc7587R5TJey+cS/060DLxexHoJ8+IfxwhOtcaHwVY/WwTlmui wajxGG7UBVtNPrqcZeUZYKNcJFpWkNJj3FRX16+6Y9gdrmHpEjYPeT+uI0qWQqxQrVJ6 4awhk64qKDbHljsvgo6+u77FrzEn3lDZHn9sviqFVe8Kf4azrtRVwcYQqU8UzRDQEVpw KWy0u+fbmsFJkJgoq8clfpdj4LNgsvYCERyZDVSIEXkGFo+D2VwUV7+Q4ttSbNBr0RVD GDULcnw+1iuclbRP8NiQcl6L3LBFSGdml9lxMhrnbQabl0g5VEKdEod3qWsjFlTHaMDd X8Zw== X-Forwarded-Encrypted: i=1; AKwUvBw8iGxVvLMrzub4mAJvmujY+Mw1QZM2IWmsPNUYU16Nf421vGAfbXMBq25wFSK/S76D8lFEGPLSJ5GoAEpkv1Zc@lists.infradead.org X-Gm-Message-State: AFuF++kaMUlfv54D+GDichiJ/BNZ5MQCSyo4OYAi53aZA0SelucrcO4C BDXkiyCX5RK7FENqJP4DhDNe+w+ulfOF+CmbG1rMUbOg6QCYl0wM9tWS X-Gm-Gg: AYBFou3uNqrCVetDt0ol+1gm6YZiRxyMyBWkp9clRM8LCovEk8Ob1MKkMkK1iYcNL8C i6X9T3u/oPiptRZ6tpk6GTGftqodg6Q80BoVx28oykNWeRAZbfssjQmSHatfUeIj8aspmfjhhSk 6iIc8IBQhmCm0MoJVlCYnmw/TlObxvBI6Zb87Xx/AjrhmQU6HJFKRURzrhjWh5wW1pcRcMXoj0U 2u2MWonaQ8MpOLxbZUDONGqK6VzbvKD0cvvhUWG76gZxNuS81CUjbOmyt0MRsxkA/+lMoxLfqIF 854q0nPAcnSQi6cMAMFq3gt7AQi5x9ivJV8N1dmG0zJ0SEGvAybhI5dORyczkYdF3Og8b66JoWD fSZE1ZkpIKtKaavPzxVInxqr9nWidLURY7ykUNhPC6zUjFPJjYFYZTbLUIafRiaqCOPaIdXvWaa dLZQcUFwlM6nSBZEr1kzjcrsKDzUk7Yu1NuOirff76u0PERDizKgtzQb042Q2ZijDFmp7Kq00I4 4ikwZqOc1mgyJYIGWvjVsnBJyDwzkzSxGfkyDEkBLYPLVxVPk+PaPacRV7gak53yz9Wz6nb8jwE clluZXbvwTgY5i0= X-Received: by 2002:a05:6a21:4a81:b0:3cd:8bba:824f with SMTP id adf61e73a8af0-3dd5f3f8a8fmr2852962637.4.1789534859652; Tue, 15 Sep 2026 22:00:59 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:00:59 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 04/12] ASoC: mediatek: mt8189: Propagate reg_rw clock errors Date: Wed, 16 Sep 2026 12:00:11 +0700 Message-ID: <20260916050020.14575-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260916_060102_374700_23DEE8EA X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: bui duc phuc mt8189_afe_enable_reg_rw_clk() currently ignores errors from clock enable and parent operations. Propagate these errors and clean up the clocks before returning the error. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- Changes in v2: - Update the names of the goto labels. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 31 +++++++++++++++++----- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c index 7fe9d01006d5..1132c924158d 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -700,17 +700,36 @@ int mt8189_mck_disable(struct mtk_base_afe *afe, int mck_id) int mt8189_afe_enable_reg_rw_clk(struct mtk_base_afe *afe) { struct mt8189_afe_private *afe_priv = afe->platform_priv; + int ret; /* bus clock for AFE internal access, like AFE SRAM */ - mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]); - mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS], - afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + ret = mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]); + if (ret) + return ret; + + ret = mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS], + afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + if (ret) + goto err_disable_audiointbus_clk; + /* enable audio clock source */ - mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); - mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H], - afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + ret = mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); + if (ret) + goto err_disable_audiointbus_clk; + + ret = mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H], + afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + if (ret) + goto err_disable_audio_h_clk; return 0; + +err_disable_audio_h_clk: + mt8189_afe_disable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); +err_disable_audiointbus_clk: + mt8189_afe_disable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]); + + return ret; } int mt8189_afe_disable_reg_rw_clk(struct mtk_base_afe *afe) -- 2.43.0