Re: [PATCH v3 6/9] EDAC/aspeed: Replace regmap with direct register access

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] cleanup: mixing goto and scoped_guard() in aspeed_probe()
--

commit c14b25ad0230e696e88f285c08700b9c02f83c19
Author: Ryan Chen <ryan_chen@aspeedtech.com>

EDAC/aspeed: Replace regmap with direct register access

This commit replaces the regmap-based MMIO access in the aspeed-edac driver
with direct register access using readl()/writel(). It introduces an
explicit raw spinlock and annotates the register base with __guarded_by()
to allow compiler-based context analysis checks.

> diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c
> index 352910e1defc5..26d2c456cc0d6 100644
> --- a/drivers/edac/aspeed_edac.c
> +++ b/drivers/edac/aspeed_edac.c
[ ... ]
> @@ -274,13 +246,11 @@ static int aspeed_probe(struct platform_device *pdev)
>  	if (IS_ERR(regs))
>  		return PTR_ERR(regs);
>  
> -	aspeed_regmap = devm_regmap_init(dev, NULL, (__force void *)regs,
> -					 &aspeed_regmap_config);
> -	if (IS_ERR(aspeed_regmap))
> -		return PTR_ERR(aspeed_regmap);
> +	scoped_guard(raw_spinlock_irqsave, &aspeed_lock)
> +		aspeed_regs = regs;

[Severity: Low]
Does this mix scope-based cleanup helpers with goto-based error handling in
the same function? The subsystem cleanup guidelines explicitly forbid mixing
goto-based error handling with scope-based cleanup helpers (like
scoped_guard) to prevent ownership confusion and leaks.

Looking further down in aspeed_probe(), the function still relies on goto
for error cleanup:

> -	/* bail out if ECC mode is not configured */
> -	regmap_read(aspeed_regmap, ASPEED_MCR_CONF, &reg04);
> +	reg04 = readl(regs + ASPEED_MCR_CONF);
[ ... ]
>  	/* register interrupt handler and enable interrupts */
>  	rc = config_irq(mci, pdev);
>  	if (rc) {
>  		dev_err(&pdev->dev, "failed setting up irq\n");
>  		goto probe_exit01;
>  	}
>  
>  	return 0;
>  
>  probe_exit01:
>  	edac_mc_del_mc(&pdev->dev);
>  probe_exit02:
>  	edac_mc_free(mci);
>  	return rc;
>  }

Should this function either be completely converted to scope-based cleanup,
or stick entirely to goto-based cleanup to avoid this pattern violation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-edac-v3-0-23e9ed2fbdf9@aspeedtech.com?part=6