From: Ido Schimmel <idosch@nvidia.com>
To: Quentin Armitage <quentin@armitage.org.uk>
Cc: David Ahern <dsahern@kernel.org>, netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: allow IFLA_INET_CONF messages when NLA_F_NESTED unset
Date: Wed, 16 Sep 2026 10:05:12 +0300 [thread overview]
Message-ID: <20260916070512.GA846427@shredder> (raw)
In-Reply-To: <20260915213320.1527029-2-quentin@armitage.org.uk>
On Tue, Sep 15, 2026 at 10:33:21PM +0100, Quentin Armitage wrote:
> Commit fa8fca88714c ("ipv4: validate IPV4_DEVCONF attributes properly")
> added validation of IFLA_INET_CONF attributes, and in the process
> changed the call of nla_for_each_nested() to nla_parse_nested(). A
> side effect of this change is that the IFLA_INET_CONF option is now
> tested for NLA_F_NESTED being set, and fails if it is not. Prior to the
> commit there was no check of NLA_F_NESTED.
>
> Change nla_parse_nested() to nla_parse(). This restores the previous
> functionality of not checking NLA_F_NESTED, thereby allowing code that
> (incorrectly) doesn't set NLA_F_NESTED to continue to work.
>
> This issue was identified because keepalived started logging errors when
> it was configuring macvlans that it created.
>
> Fixes: fa8fca88714c ("ipv4: validate IPV4_DEVCONF attributes properly")
>
> Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
For next time (assuming there won't be v4):
1. No blank line between Fixes tag and SoB.
2. Specify the target tree in subject prefix.
In this case: [PATCH net v3]
3. Post as separate thread, not as a reply.
4. Use scripts/get_maintainer.pl to get the list of recipients.
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2026-09-16 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 19:02 [PATCH v2] net: parsing IFLA_INET_CONF broken since 7.1 if NLA_F_NESTED not set Quentin Armitage
2026-09-15 14:05 ` Ido Schimmel
2026-09-15 21:33 ` [PATCH v3] net: allow IFLA_INET_CONF messages when NLA_F_NESTED unset Quentin Armitage
2026-09-16 7:05 ` Ido Schimmel [this message]
2026-09-19 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916070512.GA846427@shredder \
--to=idosch@nvidia.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin@armitage.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.