From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5865443D51E for ; Wed, 16 Sep 2026 07:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789543059; cv=none; b=JPGaqBOJAicnkDbRo6jBWFp4RKRZ+VFeEWASGu80/d/fohMYmRdHkwbwb7iddI/+UOcB80zOOfEFhHhR+Skg1SjgETGzmTu4x24VCmOlyef+BOfg1iG4wZ4EuwNCoYgedRJ1MaPSxZu7V7c5DWKyB1/JCM9TkYtGVqop3BGeB/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789543059; c=relaxed/simple; bh=NmfTorG6JVpIJFzytaD6ZeQ9avNSPqXZwe308hn+vMs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=NeHvIHSefINEidN4g2Vgti/hrweAMEPFrG/DU6AHMPEsc+zaTSSlkZiYNYbi3T2jXYwIJguL+up+Vg9FkJohlABNV3S0TPF7fqMrKxAPFz52uqXQMnwu2ZUtUvqEQRQ+Dj6LB9uHn5giyzsguPEWzyex+nIPrsQH/YjtsKVDTIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k7/Mm7dV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k7/Mm7dV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DE1E1F00893; Wed, 16 Sep 2026 07:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789543055; bh=hca6qlN0xG1kIjyBog37y2qFhd0a9XvurL53zkwuwi0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=k7/Mm7dVt5zYYTPipOh999z1bV3kgJyZyr7dUj7JJY59Sw/QekkosBvVH2CICd5FW NMBdpl6ws26ombciDhWU02rTrMEEGV8q+dK6SYvBTcVoHZEZXRswQm+MgqfCzJUoQF xmL242H7I+KCzAZvgav6AyczM+NtOMtsvAGNX2ahIDki3RdZMu4ckayiAbIXklYmIV XSlgYXFwOOItL/lJ9PiPQr0cijh3MqLEqhRNluOFnZP8h04NS8S6micmgYDoxRCQCY WL0Uq6kLlJyZGZxvG/xigZjGAj5FkPE+10OWKZxZ7dLD++MS9Lw0XHtRltUXOkNOV8 2DOGl1vp9rRPQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub Reply-To: sashiko-reviews@lists.linux.dev To: "Lakshay Piplani" Cc: linux-i3c@lists.infradead.org, Frank.Li@kernel.org, "Alexandre Belloni" , robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260916070728.1088801-6-lakshay.piplani@nxp.com> References: <20260916070728.1088801-1-lakshay.piplani@nxp.com> <20260916070728.1088801-6-lakshay.piplani@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 16 Sep 2026 07:17:34 +0000 Message-Id: <20260916071734.8DE1E1F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Low] regulator: p3h2x4x: unused fields and dead code in driver data - [Low] mfd: driver-specific header placed in global include/linux/mfd/ dir= ectory -- commit 24a75a3dc0fb9f5c1adccf0bcd6a9d774397dc1c Author: Aman Kumar Pandey regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c= hub This commit adds a regulator driver for the on-die voltage regulators integrated in the NXP P3H2x4x i3c hub family. It registers the regulators via the MFD framework and standard regulator APIs. > diff --git a/drivers/regulator/p3h2840_i3c_hub_regulator.c b/drivers/regu= lator/p3h2840_i3c_hub_regulator.c > new file mode 100644 > index 0000000000000..244f2a4f70f38 > --- /dev/null > +++ b/drivers/regulator/p3h2840_i3c_hub_regulator.c > @@ -0,0 +1,289 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright 2025-2026 NXP > + * NXP P3H2X4X regulator driver file contain functions for enable/disabl= e regulator > + * and voltage set/get. > + */ > +#include > +#include > +#include ^^^^^^^^^^^^^^^^^^^^^^^^^ [Severity: Low] Is this driver-specific header used only by the parent and its immediate children? The MFD subsystem guidelines state that driver-specific header files should= not be placed in the global include/linux/mfd/ directory if they are only used by the parent and its immediate children. Could this header be kept local to drivers/mfd/ instead? [ ... ] > +#define P3H2X4X_VCCIO_LDO_CONF 0x16 > +#define P3H2X4X_CP0_VCCIO_LDO_VOLTAGE_MASK GENMASK(1, 0) > +#define P3H2X4X_CP0_VCCIO_LDO_VOLTAGE(x) \ > + FIELD_PREP(P3H2X4X_CP0_VCCIO_LDO_VOLTAGE_MASK, x) > +#define P3H2X4X_CP1_VCCIO_LDO_VOLTAGE_MASK GENMASK(3, 2) > +#define P3H2X4X_CP1_VCCIO_LDO_VOLTAGE(x) \ > + FIELD_PREP(P3H2X4X_CP1_VCCIO_LDO_VOLTAGE_MASK, x) > +#define P3H2X4X_TP0145_VCCIO_LDO_VOLTAGE_MASK GENMASK(5, 4) > +#define P3H2X4X_TP0145_VCCIO_LDO_VOLTAGE(x) \ > + FIELD_PREP(P3H2X4X_TP0145_VCCIO_LDO_VOLTAGE_MASK, x) > +#define P3H2X4X_TP2367_VCCIO_LDO_VOLTAGE_MASK GENMASK(7, 6) > +#define P3H2X4X_TP2367_VCCIO_LDO_VOLTAGE(x) \ > + FIELD_PREP(P3H2X4X_TP2367_VCCIO_LDO_VOLTAGE_MASK, x) [Severity: Low] Are the P3H2X4X_*_VCCIO_LDO_VOLTAGE() macros used anywhere? They appear to be defined using FIELD_PREP but never utilized in the driver code, adding unnecessary complexity. > +#define P3H2X4X_LDO_COUNT 4 > +#define P3H2X4X_LDO_ENABLE_TIME_US 5000 > + > +struct p3h2x4x_regulator_dev { > + struct regulator_dev *rp3h2x4x_dev[P3H2X4X_LDO_COUNT]; > + struct p3h2x4x *p3h2x4x; > + struct regmap *regmap; > +}; [Severity: Low] Are the rp3h2x4x_dev and regmap fields needed in this structure? During p3h2x4x_regulator_probe(), these fields are populated but they don't= seem to be read anywhere on any subsequent execution path. For example, regmap a= ccess uses rdev->regmap directly from the regulator core. Could they be removed to reduce memory overhead and driver data payload complexity? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260916070728.1088= 801-1-lakshay.piplani@nxp.com?part=3D5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAC1FC88E5C for ; Wed, 16 Sep 2026 07:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HMwLa2rNAHuz3GTH6Q7hW1bnfqz7HbRJophZjpFjBsY=; b=nzSKL4GNuPsbGA Ar2v9/g9aWP/P91N+K7piQtx9HRzWdTZAlW/ta/1T1ETrxYdMlcZXU3BQmYz9eIsTixL1JoxZ5Pc5 yQpNLaJZT0acmIqpFHNjoL51lGORL0FG3Rgf4uoGP2L3bAxNVMvPzrxTnBaQTYgOmYghpqhJdMbG6 v5uwjn/Fjp4Sz+byBIFDdydoOGZb0vInQ2n6HaSOsNkb/FZ3Y49HVPElOjdlriWj2v0Bz9LxjL2gT FUWQcFSo8l3tO6xhXXsxjj1zsF0yY4o2O/LWG8pO2CISBcGDM0yB1fIDFWSj+0HmMjBsrkf8ABqLt 32gmurlFR7Bc9612OQmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6jtj-00000008Zau-1dl0; Wed, 16 Sep 2026 07:17:39 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6jtf-00000008ZaO-3npi for linux-i3c@lists.infradead.org; Wed, 16 Sep 2026 07:17:35 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7451143E54; Wed, 16 Sep 2026 07:17:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DE1E1F00893; Wed, 16 Sep 2026 07:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789543055; bh=hca6qlN0xG1kIjyBog37y2qFhd0a9XvurL53zkwuwi0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=k7/Mm7dVt5zYYTPipOh999z1bV3kgJyZyr7dUj7JJY59Sw/QekkosBvVH2CICd5FW NMBdpl6ws26ombciDhWU02rTrMEEGV8q+dK6SYvBTcVoHZEZXRswQm+MgqfCzJUoQF xmL242H7I+KCzAZvgav6AyczM+NtOMtsvAGNX2ahIDki3RdZMu4ckayiAbIXklYmIV XSlgYXFwOOItL/lJ9PiPQr0cijh3MqLEqhRNluOFnZP8h04NS8S6micmgYDoxRCQCY WL0Uq6kLlJyZGZxvG/xigZjGAj5FkPE+10OWKZxZ7dLD++MS9Lw0XHtRltUXOkNOV8 2DOGl1vp9rRPQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub To: "Lakshay Piplani" Cc: linux-i3c@lists.infradead.org, Frank.Li@kernel.org, "Alexandre Belloni" , robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260916070728.1088801-6-lakshay.piplani@nxp.com> References: <20260916070728.1088801-1-lakshay.piplani@nxp.com> <20260916070728.1088801-6-lakshay.piplani@nxp.com> Date: Wed, 16 Sep 2026 07:17:34 +0000 Message-Id: <20260916071734.8DE1E1F00893@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gcmVndWxhdG9yOiBwM2gy eDR4OiB1bnVzZWQgZmllbGRzIGFuZCBkZWFkIGNvZGUgaW4gZHJpdmVyIGRhdGEKLSBbTG93XSBt ZmQ6IGRyaXZlci1zcGVjaWZpYyBoZWFkZXIgcGxhY2VkIGluIGdsb2JhbCBpbmNsdWRlL2xpbnV4 L21mZC8gZGlyZWN0b3J5Ci0tCgpjb21taXQgMjRhNzVhM2RjMGZiOWY1YzFhZGNjZjBiY2Q2YTlk Nzc0Mzk3ZGMxYwpBdXRob3I6IEFtYW4gS3VtYXIgUGFuZGV5IDxhbWFuLmt1bWFycGFuZGV5QG54 cC5jb20+CgogICAgcmVndWxhdG9yOiBwM2gyeDR4OiBBZGQgZHJpdmVyIGZvciBvbi1kaWUgcmVn dWxhdG9ycyBpbiBOWFAgUDNIMng0eCBpM2MgaHViCgpUaGlzIGNvbW1pdCBhZGRzIGEgcmVndWxh dG9yIGRyaXZlciBmb3IgdGhlIG9uLWRpZSB2b2x0YWdlIHJlZ3VsYXRvcnMKaW50ZWdyYXRlZCBp biB0aGUgTlhQIFAzSDJ4NHggaTNjIGh1YiBmYW1pbHkuIEl0IHJlZ2lzdGVycyB0aGUgcmVndWxh dG9ycwp2aWEgdGhlIE1GRCBmcmFtZXdvcmsgYW5kIHN0YW5kYXJkIHJlZ3VsYXRvciBBUElzLgoK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9yZWd1bGF0b3IvcDNoMjg0MF9pM2NfaHViX3JlZ3VsYXRv ci5jIGIvZHJpdmVycy9yZWd1bGF0b3IvcDNoMjg0MF9pM2NfaHViX3JlZ3VsYXRvci5jCj4gbmV3 IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi4yNDRmMmE0ZjcwZjM4Cj4g LS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvcmVndWxhdG9yL3AzaDI4NDBfaTNjX2h1Yl9y ZWd1bGF0b3IuYwo+IEBAIC0wLDAgKzEsMjg5IEBACj4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlm aWVyOiBHUEwtMi4wCj4gKy8qCj4gKyAqIENvcHlyaWdodCAyMDI1LTIwMjYgTlhQCj4gKyAqIE5Y UCBQM0gyWDRYIHJlZ3VsYXRvciBkcml2ZXIgZmlsZSBjb250YWluIGZ1bmN0aW9ucyBmb3IgZW5h YmxlL2Rpc2FibGUgcmVndWxhdG9yCj4gKyAqIGFuZCB2b2x0YWdlIHNldC9nZXQuCj4gKyAqLwo+ ICsjaW5jbHVkZSA8bGludXgvYml0ZmllbGQuaD4KPiArI2luY2x1ZGUgPGxpbnV4L2NsZWFudXAu aD4KPiArI2luY2x1ZGUgPGxpbnV4L21mZC9wM2gyODQwLmg+CiAgICAgICAgICAgXl5eXl5eXl5e Xl5eXl5eXl5eXl5eXl5eXgoKW1NldmVyaXR5OiBMb3ddCklzIHRoaXMgZHJpdmVyLXNwZWNpZmlj IGhlYWRlciB1c2VkIG9ubHkgYnkgdGhlIHBhcmVudCBhbmQgaXRzIGltbWVkaWF0ZQpjaGlsZHJl bj8KClRoZSBNRkQgc3Vic3lzdGVtIGd1aWRlbGluZXMgc3RhdGUgdGhhdCBkcml2ZXItc3BlY2lm aWMgaGVhZGVyIGZpbGVzIHNob3VsZCBub3QKYmUgcGxhY2VkIGluIHRoZSBnbG9iYWwgaW5jbHVk ZS9saW51eC9tZmQvIGRpcmVjdG9yeSBpZiB0aGV5IGFyZSBvbmx5IHVzZWQKYnkgdGhlIHBhcmVu dCBhbmQgaXRzIGltbWVkaWF0ZSBjaGlsZHJlbi4gQ291bGQgdGhpcyBoZWFkZXIgYmUga2VwdCBs b2NhbCB0bwpkcml2ZXJzL21mZC8gaW5zdGVhZD8KClsgLi4uIF0KCj4gKyNkZWZpbmUgUDNIMlg0 WF9WQ0NJT19MRE9fQ09ORgkJCQkJMHgxNgo+ICsjZGVmaW5lIFAzSDJYNFhfQ1AwX1ZDQ0lPX0xE T19WT0xUQUdFX01BU0sJCQlHRU5NQVNLKDEsIDApCj4gKyNkZWZpbmUgUDNIMlg0WF9DUDBfVkND SU9fTERPX1ZPTFRBR0UoeCkJXAo+ICsJCUZJRUxEX1BSRVAoUDNIMlg0WF9DUDBfVkNDSU9fTERP X1ZPTFRBR0VfTUFTSywgeCkKPiArI2RlZmluZSBQM0gyWDRYX0NQMV9WQ0NJT19MRE9fVk9MVEFH RV9NQVNLCQkJR0VOTUFTSygzLCAyKQo+ICsjZGVmaW5lIFAzSDJYNFhfQ1AxX1ZDQ0lPX0xET19W T0xUQUdFKHgpCVwKPiArCQlGSUVMRF9QUkVQKFAzSDJYNFhfQ1AxX1ZDQ0lPX0xET19WT0xUQUdF X01BU0ssIHgpCj4gKyNkZWZpbmUgUDNIMlg0WF9UUDAxNDVfVkNDSU9fTERPX1ZPTFRBR0VfTUFT SwkJCUdFTk1BU0soNSwgNCkKPiArI2RlZmluZSBQM0gyWDRYX1RQMDE0NV9WQ0NJT19MRE9fVk9M VEFHRSh4KQlcCj4gKwkJRklFTERfUFJFUChQM0gyWDRYX1RQMDE0NV9WQ0NJT19MRE9fVk9MVEFH RV9NQVNLLCB4KQo+ICsjZGVmaW5lIFAzSDJYNFhfVFAyMzY3X1ZDQ0lPX0xET19WT0xUQUdFX01B U0sJCQlHRU5NQVNLKDcsIDYpCj4gKyNkZWZpbmUgUDNIMlg0WF9UUDIzNjdfVkNDSU9fTERPX1ZP TFRBR0UoeCkJXAo+ICsJCUZJRUxEX1BSRVAoUDNIMlg0WF9UUDIzNjdfVkNDSU9fTERPX1ZPTFRB R0VfTUFTSywgeCkKCltTZXZlcml0eTogTG93XQpBcmUgdGhlIFAzSDJYNFhfKl9WQ0NJT19MRE9f Vk9MVEFHRSgpIG1hY3JvcyB1c2VkIGFueXdoZXJlPwoKVGhleSBhcHBlYXIgdG8gYmUgZGVmaW5l ZCB1c2luZyBGSUVMRF9QUkVQIGJ1dCBuZXZlciB1dGlsaXplZCBpbiB0aGUgZHJpdmVyCmNvZGUs IGFkZGluZyB1bm5lY2Vzc2FyeSBjb21wbGV4aXR5LgoKPiArI2RlZmluZSBQM0gyWDRYX0xET19D T1VOVAkJCQkJNAo+ICsjZGVmaW5lIFAzSDJYNFhfTERPX0VOQUJMRV9USU1FX1VTCQkJCTUwMDAK PiArCj4gK3N0cnVjdCBwM2gyeDR4X3JlZ3VsYXRvcl9kZXYgewo+ICsJc3RydWN0IHJlZ3VsYXRv cl9kZXYgKnJwM2gyeDR4X2RldltQM0gyWDRYX0xET19DT1VOVF07Cj4gKwlzdHJ1Y3QgcDNoMng0 eCAqcDNoMng0eDsKPiArCXN0cnVjdCByZWdtYXAgKnJlZ21hcDsKPiArfTsKCltTZXZlcml0eTog TG93XQpBcmUgdGhlIHJwM2gyeDR4X2RldiBhbmQgcmVnbWFwIGZpZWxkcyBuZWVkZWQgaW4gdGhp cyBzdHJ1Y3R1cmU/CgpEdXJpbmcgcDNoMng0eF9yZWd1bGF0b3JfcHJvYmUoKSwgdGhlc2UgZmll bGRzIGFyZSBwb3B1bGF0ZWQgYnV0IHRoZXkgZG9uJ3Qgc2VlbQp0byBiZSByZWFkIGFueXdoZXJl IG9uIGFueSBzdWJzZXF1ZW50IGV4ZWN1dGlvbiBwYXRoLiBGb3IgZXhhbXBsZSwgcmVnbWFwIGFj Y2Vzcwp1c2VzIHJkZXYtPnJlZ21hcCBkaXJlY3RseSBmcm9tIHRoZSByZWd1bGF0b3IgY29yZS4g Q291bGQgdGhleSBiZSByZW1vdmVkIHRvCnJlZHVjZSBtZW1vcnkgb3ZlcmhlYWQgYW5kIGRyaXZl ciBkYXRhIHBheWxvYWQgY29tcGxleGl0eT8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRw czovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA5MTYwNzA3MjguMTA4ODgwMS0xLWxha3No YXkucGlwbGFuaUBueHAuY29tP3BhcnQ9NQoKLS0gCmxpbnV4LWkzYyBtYWlsaW5nIGxpc3QKbGlu dXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1pM2MK