From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2C13C88E77 for ; Wed, 16 Sep 2026 07:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jufRe5EW7v0R1ER/nveHCTEHv9CaNWBQJuvnoFs82ns=; b=4ebWt3s4bvgSf2 LRZrwoMeUMUIbn/RzlZKI2qEJD+TOlvAY+tiIgFHQIcbgO/CuJ02+DILqPO4VDrgUc4j3OuP4oXZ/ CNQO+cqplkugZH91Oj2dz9BehCdcRhp4oQ7JNmWEqKk7fuuX8x/XtfZUYeMmonYXkElPCJm2QwnWh f5OgzpBpQztKBMNSpu95mJzYFBFmQ7IjVMt8HzJI1Jx3Hi/E0My58DxtKIya2FH0wtGtKgKCFf6nE 8BRViGX8c/C2hJQIAzHjq4jVOx047ROQd8nJoJwtGxEfPEG6G1gLRyxaAHROWjGnG9nMz9jbdjC0M vyFl9bT4+wlsS76iKNgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6jxV-00000008a45-21qm; Wed, 16 Sep 2026 07:21:33 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6jxR-00000008a3B-09z8 for linux-i3c@lists.infradead.org; Wed, 16 Sep 2026 07:21:32 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 568D56020C; Wed, 16 Sep 2026 07:21:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D741F00893; Wed, 16 Sep 2026 07:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789543288; bh=PZO+C+d6FTo05ZYUZnR1OYIaXW743DjTwjtKF9v44dI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ch8BSRJ9G16DbZLwOEBOUpsYrpaTB6pp7muVXpfN6IGTf5pKc7TMoEoSTWri/72Pu 0AXGhS/1poNjcxRZCyQfZOnxIMiCtP+5moMj6FkQBUFHyd0ggCYR6dUeqRa3fQeuAR qhH2HmaqK2llpmeld3jVgz9guYM5VlFVJVyuMMRMOUtUIhI5Lvv1uZq6s7cFbCEmmq H/xKVLPE6JEAahGl8sQNuB55khSPafKc2+6/lfaEHPY7dBMn4FHVT7U34pL4XADcN3 fpzIvdDPN2qgvCOZ6KZxP/vMopWjb8zWqM5RlGxtdAvOaeBzo6avXJowwgDGGrFKNi G5yQIaKjUf1SQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 6/8] i3c: hub: Add support for the I3C interface in the I3C hub To: "Lakshay Piplani" Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org, robh@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org, "Alexandre Belloni" In-Reply-To: <20260916070728.1088801-7-lakshay.piplani@nxp.com> References: <20260916070728.1088801-1-lakshay.piplani@nxp.com> <20260916070728.1088801-7-lakshay.piplani@nxp.com> Date: Wed, 16 Sep 2026 07:21:27 +0000 Message-Id: <20260916072127.A5D741F00893@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGkzYzogaHViOiBkeW5h bWljYWxseSBkaXNjb3ZlcmVkIGRldmljZXMgYXR0YWNoIHRvIHdyb25nIGJ1cyBieXBhc3Npbmcg cG9ydAotIFtNZWRpdW1dIGkzYzogaHViOiBjYXNjYWRlZCBodWJzIGZhaWwgdG8gcHJvcGFnYXRl IGFkZHJlc3MgcmVzZXJ2YXRpb25zIHRvIHJvb3QgYnVzCi0tCgpjb21taXQgOWZiOGFkNzVjZjc3 MWZiYTljMWI2YmRmZWM3Y2E2Y2QxY2I2MDA0MQpBdXRob3I6IExha3NoYXkgUGlwbGFuaSA8bGFr c2hheS5waXBsYW5pQG54cC5jb20+CgppM2M6IGh1YjogQWRkIHN1cHBvcnQgZm9yIHRoZSBJM0Mg aW50ZXJmYWNlIGluIHRoZSBJM0MgaHViCgpUaGlzIHBhdGNoIGFkZHMgdmlydHVhbCBJM0MgYnVz IHN1cHBvcnQgZm9yIGh1YnMgYnkgY3JlYXRpbmcgdmlydHVhbAptYXN0ZXIgY29udHJvbGxlcnMg Zm9yIGRvd25zdHJlYW0gcG9ydHMgYW5kIGZvcndhcmRpbmcgYnVzIG9wZXJhdGlvbnMKdGhyb3Vn aCB0aGUgaHViIGRldmljZS4gSXQgYWxzbyBwcm92aWRlcyBhbiBpbnRlcmZhY2UgdXNlZCBieSBo dWIKZHJpdmVycyB0byBlbmFibGUgb3IgZGlzYWJsZSBkb3duc3RyZWFtIHBvcnRzIGR1cmluZyBi dXMgdHJhbnNhY3Rpb25zLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pM2MvaHViLmMgYi9kcml2 ZXJzL2kzYy9odWIuYwo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAw MC4uNTM5MDI4NzY4MDg0NAo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJzL2kzYy9odWIu Ywo+IEBAIC0wLDAgKzEsODMyIEBAClsgLi4uIF0KPiArc3RhdGljIGludCBpM2NfaHViX2RvX2Rh YShzdHJ1Y3QgaTNjX2h1YiAqaHViLAo+ICsJCQkgIHN0cnVjdCBpM2NfbWFzdGVyX2NvbnRyb2xs ZXIgKmNvbnRyb2xsZXIpCj4gK3sKWyAuLi4gXQo+ICsJLyoKPiArCSAqIERvd25zdHJlYW0gZGV2 aWNlcyByZWFjaGFibGUgdGhyb3VnaCBodWIgdGFyZ2V0LXBvcnQgcm91dGVzIHNoYXJlIHRoZQo+ ICsJICogcGFyZW50IGNvbnRyb2xsZXIncyBJM0MgYWRkcmVzcyBzcGFjZS4gVGhlIGh1YiBnYXRl cyBhY2Nlc3MgdG8gYQo+ICsJICogdGFyZ2V0LXBvcnQgbmV0d29yaywgYnV0IGl0IGRvZXMgbm90 IGNyZWF0ZSBhbiBpbmRlcGVuZGVudCBkeW5hbWljCj4gKwkgKiBhZGRyZXNzIGRvbWFpbiBwZXIg dmlydHVhbCBidXMuCj4gKwkgKgo+ICsJICogUnVuIERBQSBvbiB0aGUgcGFyZW50IGNvbnRyb2xs ZXIgc28gZHluYW1pYyBhZGRyZXNzZXMgcmVtYWluIHVuaXF1ZQo+ICsJICogYWNyb3NzIGFsbCBk b3duc3RyZWFtIGRldmljZXMsIGV2ZW4gd2hlbiB0aGV5IGFyZSBiZWhpbmQgZGlmZmVyZW50Cj4g KwkgKiB0YXJnZXQgcG9ydHMuCj4gKwkgKgo+ICsJICogVGhlIGN1cnJlbnQgaHViIG1vZGVsIHNo YXJlcyB0aGUgcGFyZW50IGNvbnRyb2xsZXIncyBkeW5hbWljLWFkZHJlc3MKPiArCSAqIGRvbWFp biBhbmQgZG9lcyBub3Qgc3VwcG9ydCBpbmRlcGVuZGVudCBwZXItcG9ydCBEQUEgZG9tYWlucywg c28gYQo+ICsJICogREFBIHJlc3VsdCBkb2VzIG5vdCBnbyBzdGFsZSBiZWhpbmQgYSBwb3J0IHRv Z2dsZS4gQWRkcmVzc2VzIHJlc2VydmVkCj4gKwkgKiBmcm9tIHRoZSBEZXZpY2UgVHJlZSBhcmUg aGVsZCBmb3IgdGhlIGxpZmV0aW1lIG9mIHRoZSBwYXJlbnQgYnVzIGFuZAo+ICsJICogYXJlIG5l dmVyIHJlbGVhc2VkIG9uIGEgcG9ydCB0b2dnbGUsIHNvIGVuYWJsaW5nIG9yIGRpc2FibGluZyBh IHBvcnQKPiArCSAqIG9ubHkgZ2F0ZXMgcmVhY2hhYmlsaXR5IGFuZCBuZXZlciBjYXVzZXMgYW4g YWRkcmVzcyB0byBiZSBoYW5kZWQgb3V0Cj4gKwkgKiB0d2ljZS4KPiArCSAqLwo+ICsJcmV0ID0g aTNjX21hc3Rlcl9kb19kYWEocGFyZW50KTsKCltTZXZlcml0eTogSGlnaF0KV2hlbiBpM2NfaHVi X2RvX2RhYSgpIGZvcndhcmRzIERBQSB0byB0aGUgcGFyZW50IGNvbnRyb2xsZXIgaGVyZSwgd29u J3QKdGhlIHBhcmVudCBkaXNjb3ZlciB0aGUgZG93bnN0cmVhbSBkZXZpY2UgYW5kIGFkZCBpdCB0 byBpdHMgb3duCnBhcmVudC0+YnVzLmRldnMuaTNjIGxpc3QgaW5zdGVhZCBvZiB0aGUgdmlydHVh bCBidXM/CgpJZiBhIGRvd25zdHJlYW0gZGV2aWNlIHdpdGhvdXQgYSBzdGF0aWMgYWRkcmVzcyBj b25uZWN0cyBiZWhpbmQgdGhlIGh1Ygpwb3J0LCBhbmQgdGhlIHBoeXNpY2FsIHBhcmVudCBjb250 cm9sbGVyIG93bnMgdGhlIGRldmljZSByZWNvcmQsIHN1YnNlcXVlbnQKSS9PIHdpbGwgdXNlIHRo ZSBwYXJlbnQncyBpM2NfeGZlcnMoKSBpbXBsZW1lbnRhdGlvbi4gRG9lcyB0aGlzIHBlcm1hbmVu dGx5CmJ5cGFzcyB0aGUgdmlydHVhbCBodWIgY29udHJvbGxlciwgbWVhbmluZyB0aGUgaTNjX2h1 Yl9lbmFibGVfcG9ydCgpIHJvdXRpbmcKbG9naWMgaXMgbmV2ZXIgdHJpZ2dlcmVkIGZvciB0aGVz ZSBkZXZpY2VzIGFuZCB0cmFuc2ZlcnMgd2lsbCBmYWlsPwoKPiArCWkzY19odWJfZGlzYWJsZV9w b3J0KGNvbnRyb2xsZXIpOwo+ICsJbXV0ZXhfdW5sb2NrKCZodWItPmxvY2spOwo+ICsKPiArCXJl dHVybiByZXQ7Cj4gK30KWyAuLi4gXQo+ICtpbnQgaTNjX2h1Yl9yZXNlcnZlX3BhcmVudF9hZGRy c2xvdHNfZnJvbV9kdChzdHJ1Y3QgaTNjX2h1Yl9jb250cm9sbGVyICpodWJjLAo+ICsJCQkJCSAg ICAgc3RydWN0IGRldmljZV9ub2RlICpub2RlKQo+ICt7ClsgLi4uIF0KPiArCQlpM2NfYnVzX21h aW50ZW5hbmNlX2xvY2soJnBhcmVudC0+YnVzKTsKPiArCQlzdGF0dXMgPSBpM2NfYnVzX2dldF9h ZGRyX3Nsb3Rfc3RhdHVzKCZwYXJlbnQtPmJ1cywKPiArCQkJCQkJICAgICAgYXNzaWduZWRfYWRk cik7Cj4gKwkJaWYgKHN0YXR1cyA9PSBJM0NfQUREUl9TTE9UX0ZSRUUpCj4gKwkJCWkzY19idXNf c2V0X2FkZHJfc2xvdF9zdGF0dXMoJnBhcmVudC0+YnVzLAo+ICsJCQkJCQkgICAgIGFzc2lnbmVk X2FkZHIsCj4gKwkJCQkJCSAgICAgSTNDX0FERFJfU0xPVF9JM0NfREVWKTsKCltTZXZlcml0eTog TWVkaXVtXQpJbiBhIGNhc2NhZGVkIGh1YiB0b3BvbG9neSwgd29uJ3QgdGhpcyBvbmx5IHVwZGF0 ZSB0aGUgYWRkcnNsb3RzIGJpdG1hcApvZiB0aGUgaW1tZWRpYXRlIHBhcmVudC0+YnVzICh3aGlj aCBpcyB0aGUgdXBzdHJlYW0gaHViJ3MgdmlydHVhbCBidXMpPwoKU2luY2UgREFBIGlzIHJlY3Vy c2l2ZWx5IGZvcndhcmRlZCB0byB0aGUgcm9vdCBwaHlzaWNhbCBjb250cm9sbGVyLCB0aGF0CnJv b3QgY29udHJvbGxlciBhc3NpZ25zIGR5bmFtaWMgYWRkcmVzc2VzIGJhc2VkIG9uIGl0cyBvd24g YWRkcnNsb3RzIGJpdG1hcC4KRG9lcyB0aGlzIG1lYW4gdGhlIG5lc3RlZCBhZGRyZXNzIHJlc2Vy dmF0aW9ucyBmYWlsIHRvIHJlYWNoIHRoZSByb290IGJ1cywKcG90ZW50aWFsbHkgbGVhZGluZyB0 byBkeW5hbWljIGFkZHJlc3MgY29sbGlzaW9ucyBpZiB0aGUgcm9vdCBjb250cm9sbGVyCmFzc2ln bnMgdGhlc2UgcmVzZXJ2ZWQgYWRkcmVzc2VzIHRvIG5ld2x5IGRpc2NvdmVyZWQgZGV2aWNlcz8K Cj4gKwkJaTNjX2J1c19tYWludGVuYW5jZV91bmxvY2soJnBhcmVudC0+YnVzKTsKPiArCX0KPiAr CXJldHVybiAwOwo+ICt9CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtv LmRldi8jL3BhdGNoc2V0LzIwMjYwOTE2MDcwNzI4LjEwODg4MDEtMS1sYWtzaGF5LnBpcGxhbmlA bnhwLmNvbT9wYXJ0PTYKCi0tIApsaW51eC1pM2MgbWFpbGluZyBsaXN0CmxpbnV4LWkzY0BsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtaTNjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F396B440643 for ; Wed, 16 Sep 2026 07:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789543319; cv=none; b=b6wtLKc2ylNn4I3WGlDmGHEj2HeZMcslkAYFBvIlGH/hYWogL0d3hVecaz53bgE24y7IqAl53xDOW3jxzHqNTGASoGZ7+l9ukKP0yBoeKW+bRUQuIMrabQA2NeKKDau6gXuqh8YKsHfYc/7lgeJlkYFDWEziu+bGEVSuZD8iDa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789543319; c=relaxed/simple; bh=qKDZpjzJBfAMMleDECDXmrFAiXKIhYAG6zeXIgLZqB8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=YXXIJ0c/ATV2wMJSfWe0dKOainZC+pEKxGb6oCIlXNMMLs1ffyrhwfDHHM4LUY1U1NX+hKwrOO5rr2ilalk+ln7iYVtokRZmuVDfRpff1j+Ab8y/e37JO6lXBNykE8ORr9EYw2AKsSLoWmG8ir6lP2OqSVy66NmrLmtVmzUGbC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ch8BSRJ9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ch8BSRJ9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D741F00893; Wed, 16 Sep 2026 07:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789543288; bh=PZO+C+d6FTo05ZYUZnR1OYIaXW743DjTwjtKF9v44dI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ch8BSRJ9G16DbZLwOEBOUpsYrpaTB6pp7muVXpfN6IGTf5pKc7TMoEoSTWri/72Pu 0AXGhS/1poNjcxRZCyQfZOnxIMiCtP+5moMj6FkQBUFHyd0ggCYR6dUeqRa3fQeuAR qhH2HmaqK2llpmeld3jVgz9guYM5VlFVJVyuMMRMOUtUIhI5Lvv1uZq6s7cFbCEmmq H/xKVLPE6JEAahGl8sQNuB55khSPafKc2+6/lfaEHPY7dBMn4FHVT7U34pL4XADcN3 fpzIvdDPN2qgvCOZ6KZxP/vMopWjb8zWqM5RlGxtdAvOaeBzo6avXJowwgDGGrFKNi G5yQIaKjUf1SQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 6/8] i3c: hub: Add support for the I3C interface in the I3C hub Reply-To: sashiko-reviews@lists.linux.dev To: "Lakshay Piplani" Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org, robh@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org, "Alexandre Belloni" In-Reply-To: <20260916070728.1088801-7-lakshay.piplani@nxp.com> References: <20260916070728.1088801-1-lakshay.piplani@nxp.com> <20260916070728.1088801-7-lakshay.piplani@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 16 Sep 2026 07:21:27 +0000 Message-Id: <20260916072127.A5D741F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] i3c: hub: dynamically discovered devices attach to wrong bus bypas= sing port - [Medium] i3c: hub: cascaded hubs fail to propagate address reservations t= o root bus -- commit 9fb8ad75cf771fba9c1b6bdfec7ca6cd1cb60041 Author: Lakshay Piplani i3c: hub: Add support for the I3C interface in the I3C hub This patch adds virtual I3C bus support for hubs by creating virtual master controllers for downstream ports and forwarding bus operations through the hub device. It also provides an interface used by hub drivers to enable or disable downstream ports during bus transactions. > diff --git a/drivers/i3c/hub.c b/drivers/i3c/hub.c > new file mode 100644 > index 0000000000000..5390287680844 > --- /dev/null > +++ b/drivers/i3c/hub.c > @@ -0,0 +1,832 @@ [ ... ] > +static int i3c_hub_do_daa(struct i3c_hub *hub, > + struct i3c_master_controller *controller) > +{ [ ... ] > + /* > + * Downstream devices reachable through hub target-port routes share the > + * parent controller's I3C address space. The hub gates access to a > + * target-port network, but it does not create an independent dynamic > + * address domain per virtual bus. > + * > + * Run DAA on the parent controller so dynamic addresses remain unique > + * across all downstream devices, even when they are behind different > + * target ports. > + * > + * The current hub model shares the parent controller's dynamic-address > + * domain and does not support independent per-port DAA domains, so a > + * DAA result does not go stale behind a port toggle. Addresses reserved > + * from the Device Tree are held for the lifetime of the parent bus and > + * are never released on a port toggle, so enabling or disabling a port > + * only gates reachability and never causes an address to be handed out > + * twice. > + */ > + ret =3D i3c_master_do_daa(parent); [Severity: High] When i3c_hub_do_daa() forwards DAA to the parent controller here, won't the parent discover the downstream device and add it to its own parent->bus.devs.i3c list instead of the virtual bus? If a downstream device without a static address connects behind the hub port, and the physical parent controller owns the device record, subsequent I/O will use the parent's i3c_xfers() implementation. Does this permanently bypass the virtual hub controller, meaning the i3c_hub_enable_port() routing logic is never triggered for these devices and transfers will fail? > + i3c_hub_disable_port(controller); > + mutex_unlock(&hub->lock); > + > + return ret; > +} [ ... ] > +int i3c_hub_reserve_parent_addrslots_from_dt(struct i3c_hub_controller *= hubc, > + struct device_node *node) > +{ [ ... ] > + i3c_bus_maintenance_lock(&parent->bus); > + status =3D i3c_bus_get_addr_slot_status(&parent->bus, > + assigned_addr); > + if (status =3D=3D I3C_ADDR_SLOT_FREE) > + i3c_bus_set_addr_slot_status(&parent->bus, > + assigned_addr, > + I3C_ADDR_SLOT_I3C_DEV); [Severity: Medium] In a cascaded hub topology, won't this only update the addrslots bitmap of the immediate parent->bus (which is the upstream hub's virtual bus)? Since DAA is recursively forwarded to the root physical controller, that root controller assigns dynamic addresses based on its own addrslots bitmap. Does this mean the nested address reservations fail to reach the root bus, potentially leading to dynamic address collisions if the root controller assigns these reserved addresses to newly discovered devices? > + i3c_bus_maintenance_unlock(&parent->bus); > + } > + return 0; > +} --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260916070728.1088= 801-1-lakshay.piplani@nxp.com?part=3D6