From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC078C88E5C for ; Wed, 16 Sep 2026 07:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z0NsYMAmT8ONCYJflOVBditAd6MQ7LumSSrO32g+01M=; b=MVB5TDlkjqq8zX +YTX7gtlDyHUgWC8+g9gkpTlhNVZ+LbFPrvPsPD1xlJQ0RInkhMgxHo3WOrLUpYdNxAiOqTq0c9Bn /ayeE7diwuolydA9PKoAndLgBYbs3An85HmgYr3nkXaoUmaQ7lZMPKROODWCiGMGBVCgzV63v9m+6 0JG9ofsnhcJGQs+INOARq4UKyeCAuFyMiQL94Zd24UQT3PPki12u93EFOPlKjQIp2JQ5bieWZVAQZ sXdEl0yyn4kNt9Jr2aeXPa7BPvDq9Wvv7cxlQczz0siSC6wsBF/0tnpDwrRmg4ABXoVyNXJVsTMp7 pjcNL7NmZgXil4uNIz8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6jyn-00000008a9m-2Ww4; Wed, 16 Sep 2026 07:22:53 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6jyj-00000008a9f-3z31 for linux-i3c@lists.infradead.org; Wed, 16 Sep 2026 07:22:51 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B35A24039B; Wed, 16 Sep 2026 07:22:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C2C11F000FF; Wed, 16 Sep 2026 07:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789543369; bh=EcU7CN7CjVsnYuSepN3N2pAdFOqIDqrxhG5JtYEvsKE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=e5fRudepLUbzldkPkhvmH8KsVsNtyKgW4n26oGtxMqRwZRNXTN+n6Rrq7hWGBy+D8 BSitPsfBfdF0Y4gNhq4cloajLT/rkJi9gs+FtT9Daq+RzGYouahQwXwAOFqh3Zz74Z vODteIiEwVjtpYg7oo/BvWuIQPUVjObX5OwPGjiEJb8kPVgk7ioXchnz7xE1K+o0ky OAuecDCyY5DqEuJZMTh5ultn8EJAhk733yvyOSZoZoTxhdFTWK7qFRP12aD+TpQ1Ea IZVKzDuWUz0uenSJWPoMGhvovriy3i/aKoIEb0t3kBnHEakPOmtiD1LB2Ua70bi8pQ EGgT52Q2m2GbA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 7/8] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality To: "Lakshay Piplani" Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org, linux-i3c@lists.infradead.org, "Alexandre Belloni" , conor+dt@kernel.org, robh@kernel.org In-Reply-To: <20260916070728.1088801-8-lakshay.piplani@nxp.com> References: <20260916070728.1088801-1-lakshay.piplani@nxp.com> <20260916070728.1088801-8-lakshay.piplani@nxp.com> Date: Wed, 16 Sep 2026 07:22:48 +0000 Message-Id: <20260916072249.3C2C11F000FF@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGkzYzogVUFGIG9mIGkz Y19tYXN0ZXJfY29udHJvbGxlciBkdWUgdG8gZGV2cmVzIGFuZCBkZXZpY2VfdW5yZWdpc3RlciBt aXNtYXRjaAotIFtIaWdoXSBpM2M6IFJhY2UgY29uZGl0aW9uIGluIHRhcmdldCBwb3J0IGNvbm5l Y3Rpb24gY2F1c2VzIGVhcmx5IHRyYW5zZmVycyB0byBmYWlsCi0tCgpjb21taXQgOTk3NjQ3MjQw MmYyYjUwYjU2ZDcxMDg4ZjYwOWI0YjI0NmI1ZTI0OQpBdXRob3I6IEFtYW4gS3VtYXIgUGFuZGV5 IDxhbWFuLmt1bWFycGFuZGV5QG54cC5jb20+CgogICAgaTNjOiBodWI6IHAzaDJ4NHg6IEFkZCBz dXBwb3J0IGZvciBOWFAgUDNIMng0eCBJM0MgaHViIGZ1bmN0aW9uYWxpdHkKICAgIAogICAgQWRk IEkzQyBodWIgZnVuY3Rpb25hbGl0eSBmb3IgdGhlIE5YUCBQM0gyeDR4IGZhbWlseSBvZiBtdWx0 aXBvcnQgaHVicy4KICAgIFRoZXNlIGRldmljZXMgc3VwcG9ydCBkb3duc3RyZWFtIHRhcmdldCBw b3J0cyB0aGF0IGNhbiBiZSBjb25maWd1cmVkCiAgICBhcyBJM0MsIEkyQywgb3IgU01CdXMuCgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2kzYy9odWIvcDNoMjg0MF9pM2NfaHViX2NvbW1vbi5jIGIv ZHJpdmVycy9pM2MvaHViL3AzaDI4NDBfaTNjX2h1Yl9jb21tb24uYwo+IC0tLSAvZGV2L251bGwK PiArKysgYi9kcml2ZXJzL2kzYy9odWIvcDNoMjg0MF9pM2NfaHViX2NvbW1vbi5jClsgLi4uIF0K PiArc3RhdGljIGludCBwM2gyeDR4X2kzY19odWJfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKPiArewo+ICsJc3RydWN0IHAzaDJ4NHggKnAzaDJ4NHggPSBkZXZfZ2V0X2RydmRh dGEocGRldi0+ZGV2LnBhcmVudCk7Cj4gKwlzdHJ1Y3QgcDNoMng0eF9pM2NfaHViX2RldiAqcDNo Mng0eF9pM2NfaHViOwo+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiArCXN0 cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZTsKPiArCWludCByZXQsIGk7Cj4gKwo+ICsJcDNoMng0eF9p M2NfaHViID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9mKCpwM2gyeDR4X2kzY19odWIpLCBHRlBf S0VSTkVMKTsKPiArCWlmICghcDNoMng0eF9pM2NfaHViKQo+ICsJCXJldHVybiAtRU5PTUVNOwoK WyAuLi4gXQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pM2MvaHViL3AzaDI4NDBfaTNjX2h1Yl9p M2MuYyBiL2RyaXZlcnMvaTNjL2h1Yi9wM2gyODQwX2kzY19odWJfaTNjLmMKPiAtLS0gL2Rldi9u dWxsCj4gKysrIGIvZHJpdmVycy9pM2MvaHViL3AzaDI4NDBfaTNjX2h1Yl9pM2MuYwpbIC4uLiBd Cj4gK3N0YXRpYyB2b2lkIHAzaDJ4NHhfdW5yZWdpc3Rlcl9pM2NfbWFzdGVyKHZvaWQgKmRhdGEp Cj4gK3sKPiArCXN0cnVjdCBpM2NfbWFzdGVyX2NvbnRyb2xsZXIgKmNvbnRyb2xsZXIgPSBkYXRh Owo+ICsKPiArCWkzY19tYXN0ZXJfdW5yZWdpc3Rlcihjb250cm9sbGVyKTsKPiArfQpbIC4uLiBd Cj4gK2ludCBwM2gyeDR4X3RwX2kzY19hbGdvKHN0cnVjdCBwM2gyeDR4X2kzY19odWJfZGV2ICpw M2gyeDR4X2h1YikKPiArewpbIC4uLiBdCj4gKwlmb3IgKHRwID0gMDsgdHAgPCBwM2gyeDR4LT5u dW1fdGFyZ2V0X3BvcnRzOyB0cCsrKSB7ClsgLi4uIF0KPiArCQlyZXQgPSBpM2NfbWFzdGVyX3Jl Z2lzdGVyX2Z3bm9kZShjb250cm9sbGVyLAo+ICsJCQkJCQkgcDNoMng0eF9odWItPmRldiwKPiAr CQkJCQkJIG9mX2Z3bm9kZV9oYW5kbGUocDNoMng0eF9odWItPnRwX2J1c1t0cF0ub2Zfbm9kZSks Cj4gKwkJCQkJCSAmaTNjX2h1Yl9tYXN0ZXJfb3BzLAo+ICsJCQkJCQkgZmFsc2UpOwo+ICsJCWlm IChyZXQpCj4gKwkJCXJldHVybiByZXQ7Cj4gKwo+ICsJCXJldCA9IGRldm1fYWRkX2FjdGlvbl9v cl9yZXNldChwM2gyeDR4X2h1Yi0+ZGV2LAo+ICsJCQkJCSAgICAgICBwM2gyeDR4X3VucmVnaXN0 ZXJfaTNjX21hc3RlciwKPiArCQkJCQkgICAgICAgY29udHJvbGxlcik7Cj4gKwkJaWYgKHJldCkK PiArCQkJcmV0dXJuIHJldDsKCltTZXZlcml0eTogSGlnaF0KRG9lcyB0aGlzIGNyZWF0ZSBhIHVz ZS1hZnRlci1mcmVlIHJpc2sgZHVyaW5nIGRyaXZlciByZW1vdmFsPwoKVGhlIHAzaDJ4NHhfaTNj X2h1YiBzdHJ1Y3R1cmUgZW1iZWRzIHRoZSBpM2NfbWFzdGVyX2NvbnRyb2xsZXIgaW5zdGFuY2Vz CmFuZCBpcyBhbGxvY2F0ZWQgd2l0aCBkZXZtX2t6YWxsb2MoKSBpbiBwM2gyeDR4X2kzY19odWJf cHJvYmUoKS4gV2hlbiB0aGUKZHJpdmVyIHVuYmluZHMsIGRldnJlcyB3aWxsIGV4ZWN1dGUgcDNo Mng0eF91bnJlZ2lzdGVyX2kzY19tYXN0ZXIoKSB3aGljaApjYWxscyBpM2NfbWFzdGVyX3VucmVn aXN0ZXIoKS4KClVubGlrZSBpMmNfZGVsX2FkYXB0ZXIoKSwgaTNjX21hc3Rlcl91bnJlZ2lzdGVy KCkgY2FsbHMgZGV2aWNlX3VucmVnaXN0ZXIoKQp3aXRob3V0IHdhaXRpbmcgZm9yIHRoZSBkZXZp Y2UgcmVmZXJlbmNlIGNvdW50IHRvIHJlYWNoIHplcm8uIEJlY2F1c2UgdGhlCmRldm0gY2xlYW51 cCBwaGFzZSBleGVjdXRlcyB3aXRob3V0IGJsb2NraW5nIGZvciBmaW5hbCBkZXZpY2UgcmVsZWFz ZSwgdGhlCmRldm1fa3phbGxvYyBtZW1vcnkgY2FuIGJlIGZyZWVkIGJlZm9yZSB0aGUgZGVmZXJy ZWQgcmVsZWFzZSBjYWxsYmFjayAKKGkzY19tYXN0ZXJkZXZfcmVsZWFzZSkgcnVucy4gSWYgdXNl cnNwYWNlIGhvbGRzIGEgcmVmZXJlbmNlIChlLmcuLCB2aWEKc3lzZnMpLCB0aGlzIHdpbGwgcmVz dWx0IGluIGEgdXNlLWFmdGVyLWZyZWUgY3Jhc2ggd2hlbiB0aGUgZmluYWwgcmVmZXJlbmNlCmlz IGRyb3BwZWQuCgo+ICsKPiArCQludHdrX21hc2sgfD0gcDNoMng0eF9odWItPnRwX2J1c1t0cF0u dHBfbWFzazsKPiArCQlwM2gyeDR4X2h1Yi0+dHBfYnVzW3RwXS5pc19yZWdpc3RlcmVkID0gdHJ1 ZTsKPiArCQlwM2gyeDR4X2h1Yi0+aHViX2NvbmZpZy50cF9jb25maWdbdHBdLmFsd2F5c19lbmFi bGUgPSB0cnVlOwo+ICsJfQo+ICsJcmV0dXJuIHJlZ21hcF93cml0ZShwM2gyeDR4X2h1Yi0+cmVn bWFwLCBQM0gyWDRYX1RQX05FVF9DT05fQ09ORiwgbnR3a19tYXNrKTsKPiArfQoKW1NldmVyaXR5 OiBIaWdoXQpEb2VzIHRoaXMgbGVhdmUgYSByYWNlIHdpbmRvdyB3aGVyZSBlYXJseSB0cmFuc2Zl cnMgb24gbmV3bHkgcmVnaXN0ZXJlZCBwb3J0cwpjYW4gZmFpbD8KCldoZW4gaTNjX21hc3Rlcl9y ZWdpc3Rlcl9md25vZGUoKSAoY2FsbGVkIGVhcmxpZXIgaW4gdGhlIGxvb3ApIHJldHVybnMsIHRo ZQp2aXJ0dWFsIG1hc3RlciBpcyBleHBvc2VkIHRvIHRoZSBzeXN0ZW0gYW5kIGNhbiBiZWdpbiBh Y2NlcHRpbmcgdHJhbnNmZXJzLgpJbW1lZGlhdGVseSBhZnRlciwgYWx3YXlzX2VuYWJsZSBpcyBz ZXQgdG8gdHJ1ZSwgZGlzYWJsaW5nIHRoZSBzb2Z0d2FyZQplbmFibGVfcG9ydCBjYWxsYmFjayBs b2dpYy4gSG93ZXZlciwgdGhlIGhhcmR3YXJlIHBvcnQgZW5hYmxlIHdyaXRlIHRvClAzSDJYNFhf VFBfTkVUX0NPTl9DT05GIGhhcHBlbnMgb3V0c2lkZSB0aGUgbG9vcC4KCklmIGEgY2hpbGQgZGV2 aWNlIHByb2JlcyBvciBhIHRyYW5zZmVyIGlzIGluaXRpYXRlZCBvbiBhIHBvcnQgYmVmb3JlIHRo ZQpsb29wIGZpbmlzaGVzLCB0aGUgZW5hYmxlX3BvcnQgY2FsbGJhY2sgd2lsbCBjaGVjayBhbHdh eXNfZW5hYmxlLCBzZWUgaXQgaXMKdHJ1ZSwgYW5kIHJldHVybiB3aXRob3V0IGVuYWJsaW5nIHRo ZSBwb3J0IGluIGhhcmR3YXJlLiBUaGlzIHdvdWxkIHNlbmQgdGhlCnRyYW5zZmVyIHRvIGEgZGlz Y29ubmVjdGVkIHBoeXNpY2FsIHBvcnQgYW5kIGNhdXNlIEkvTyBlcnJvcnMgb3IgdGltZW91dHMu CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0 LzIwMjYwOTE2MDcwNzI4LjEwODg4MDEtMS1sYWtzaGF5LnBpcGxhbmlAbnhwLmNvbT9wYXJ0PTcK Ci0tIApsaW51eC1pM2MgbWFpbGluZyBsaXN0CmxpbnV4LWkzY0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtaTNjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A236442FB7 for ; Wed, 16 Sep 2026 07:22:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789543395; cv=none; b=n4jSJxnokp+Qf6vUrNEK+FwSvJOYF0+gi2ysbcD1749jkzsy9mvielmOAl3xvYuCvB+QHKGQJEl8nThwjMjMrh9lfsoNQC+LFCLQzmgP68gOuBKy/KfPsFG293gVtpYmXHAh7Iwy+tfW8erXINDVjqrJt1Xizdig/YLcDcUhQmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789543395; c=relaxed/simple; bh=QPc7f2dun9um9enKd+vZBehqhPvOXTyuugdtp0p32dI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=bdszN6wddHpoTXuzRXExRWJZ1zxXfoWX9oYfJnDM2ahnnV3TfqQukf82SMWaIOMcD32HyHzlPkD5glZmBK/3QLGGDpErOPOAHK7Vdx/Gc6AtLopTZLTqVuM9cgb9esclboj5oOL7jtx2eTyUX1sim2HaenBODT3zT1KZybwjaTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e5fRudep; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e5fRudep" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C2C11F000FF; Wed, 16 Sep 2026 07:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789543369; bh=EcU7CN7CjVsnYuSepN3N2pAdFOqIDqrxhG5JtYEvsKE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=e5fRudepLUbzldkPkhvmH8KsVsNtyKgW4n26oGtxMqRwZRNXTN+n6Rrq7hWGBy+D8 BSitPsfBfdF0Y4gNhq4cloajLT/rkJi9gs+FtT9Daq+RzGYouahQwXwAOFqh3Zz74Z vODteIiEwVjtpYg7oo/BvWuIQPUVjObX5OwPGjiEJb8kPVgk7ioXchnz7xE1K+o0ky OAuecDCyY5DqEuJZMTh5ultn8EJAhk733yvyOSZoZoTxhdFTWK7qFRP12aD+TpQ1Ea IZVKzDuWUz0uenSJWPoMGhvovriy3i/aKoIEb0t3kBnHEakPOmtiD1LB2Ua70bi8pQ EGgT52Q2m2GbA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 7/8] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality Reply-To: sashiko-reviews@lists.linux.dev To: "Lakshay Piplani" Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org, linux-i3c@lists.infradead.org, "Alexandre Belloni" , conor+dt@kernel.org, robh@kernel.org In-Reply-To: <20260916070728.1088801-8-lakshay.piplani@nxp.com> References: <20260916070728.1088801-1-lakshay.piplani@nxp.com> <20260916070728.1088801-8-lakshay.piplani@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 16 Sep 2026 07:22:48 +0000 Message-Id: <20260916072249.3C2C11F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] i3c: UAF of i3c_master_controller due to devres and device_unregis= ter mismatch - [High] i3c: Race condition in target port connection causes early transfe= rs to fail -- commit 9976472402f2b50b56d71088f609b4b246b5e249 Author: Aman Kumar Pandey i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality =20 Add I3C hub functionality for the NXP P3H2x4x family of multiport hubs. These devices support downstream target ports that can be configured as I3C, I2C, or SMBus. > diff --git a/drivers/i3c/hub/p3h2840_i3c_hub_common.c b/drivers/i3c/hub/p= 3h2840_i3c_hub_common.c > --- /dev/null > +++ b/drivers/i3c/hub/p3h2840_i3c_hub_common.c [ ... ] > +static int p3h2x4x_i3c_hub_probe(struct platform_device *pdev) > +{ > + struct p3h2x4x *p3h2x4x =3D dev_get_drvdata(pdev->dev.parent); > + struct p3h2x4x_i3c_hub_dev *p3h2x4x_i3c_hub; > + struct device *dev =3D &pdev->dev; > + struct device_node *node; > + int ret, i; > + > + p3h2x4x_i3c_hub =3D devm_kzalloc(dev, sizeof(*p3h2x4x_i3c_hub), GFP_KER= NEL); > + if (!p3h2x4x_i3c_hub) > + return -ENOMEM; [ ... ] > diff --git a/drivers/i3c/hub/p3h2840_i3c_hub_i3c.c b/drivers/i3c/hub/p3h2= 840_i3c_hub_i3c.c > --- /dev/null > +++ b/drivers/i3c/hub/p3h2840_i3c_hub_i3c.c [ ... ] > +static void p3h2x4x_unregister_i3c_master(void *data) > +{ > + struct i3c_master_controller *controller =3D data; > + > + i3c_master_unregister(controller); > +} [ ... ] > +int p3h2x4x_tp_i3c_algo(struct p3h2x4x_i3c_hub_dev *p3h2x4x_hub) > +{ [ ... ] > + for (tp =3D 0; tp < p3h2x4x->num_target_ports; tp++) { [ ... ] > + ret =3D i3c_master_register_fwnode(controller, > + p3h2x4x_hub->dev, > + of_fwnode_handle(p3h2x4x_hub->tp_bus[tp].of_node), > + &i3c_hub_master_ops, > + false); > + if (ret) > + return ret; > + > + ret =3D devm_add_action_or_reset(p3h2x4x_hub->dev, > + p3h2x4x_unregister_i3c_master, > + controller); > + if (ret) > + return ret; [Severity: High] Does this create a use-after-free risk during driver removal? The p3h2x4x_i3c_hub structure embeds the i3c_master_controller instances and is allocated with devm_kzalloc() in p3h2x4x_i3c_hub_probe(). When the driver unbinds, devres will execute p3h2x4x_unregister_i3c_master() which calls i3c_master_unregister(). Unlike i2c_del_adapter(), i3c_master_unregister() calls device_unregister() without waiting for the device reference count to reach zero. Because the devm cleanup phase executes without blocking for final device release, the devm_kzalloc memory can be freed before the deferred release callback=20 (i3c_masterdev_release) runs. If userspace holds a reference (e.g., via sysfs), this will result in a use-after-free crash when the final reference is dropped. > + > + ntwk_mask |=3D p3h2x4x_hub->tp_bus[tp].tp_mask; > + p3h2x4x_hub->tp_bus[tp].is_registered =3D true; > + p3h2x4x_hub->hub_config.tp_config[tp].always_enable =3D true; > + } > + return regmap_write(p3h2x4x_hub->regmap, P3H2X4X_TP_NET_CON_CONF, ntwk_= mask); > +} [Severity: High] Does this leave a race window where early transfers on newly registered por= ts can fail? When i3c_master_register_fwnode() (called earlier in the loop) returns, the virtual master is exposed to the system and can begin accepting transfers. Immediately after, always_enable is set to true, disabling the software enable_port callback logic. However, the hardware port enable write to P3H2X4X_TP_NET_CON_CONF happens outside the loop. If a child device probes or a transfer is initiated on a port before the loop finishes, the enable_port callback will check always_enable, see it is true, and return without enabling the port in hardware. This would send the transfer to a disconnected physical port and cause I/O errors or timeouts. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260916070728.1088= 801-1-lakshay.piplani@nxp.com?part=3D7