Re: [PATCH v3 bpf-next 02/11] libbpf: Add support for BTF kinds LOC[_PARAM|_PROTO|SEC]

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: Missing string representations for new BTF kinds
--

commit 98be00a89bec3663ddafbd1e828f7723cfe159cc
Author: Alan Maguire <alan.maguire@oracle.com>

libbpf: Add support for BTF kinds LOC[_PARAM|_PROTO|SEC]

This commit adds libbpf support for the new BTF_KIND_LOC_PARAM,
BTF_KIND_LOC_PROTO, and BTF_KIND_LOCSEC kinds. It implements data
accessors, validation checks, and handles their deduplication during
the primary and reference dedup phases.

> diff --git a/tools/lib/bpf/btf.h b/tools/lib/bpf/btf.h
> index 587172c0de089..57f12630c5d15 100644
> --- a/tools/lib/bpf/btf.h
> +++ b/tools/lib/bpf/btf.h
[ ... ]
> @@ -431,6 +445,12 @@ btf_dump__dump_type_data(struct btf_dump *d, __u32 id,
>  #define BTF_KIND_DECL_TAG	17	/* Decl Tag */
>  #define BTF_KIND_TYPE_TAG	18	/* Type Tag */
>  #define BTF_KIND_ENUM64		19	/* Enum for up-to 64bit values */
> +#define BTF_KIND_LOC_PARAM	20	/* Parameter at location */
> +#define BTF_KIND_LOC_PROTO	21	/* Parameter set at location */
> +#define BTF_KIND_LOCSEC		22	/* Section containing location info */
> +
> +struct btf_loc_param;
> +struct btf_loc;

[Severity: Low]
Should these new BTF kinds also be added to the __btf_kind_str() string
mapping function in tools/lib/bpf/libbpf.c?

When libbpf encounters errors or needs to log information about these new
types, it relies on __btf_kind_str(). Because they are missing from the
switch statement in that function, any debug or error logs formatting these
types will print "unknown" instead of their actual string names.

>  
>  static inline __u16 btf_kind(const struct btf_type *t)
>  {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916074118.1007116-1-alan.maguire@oracle.com?part=2