Re: [PATCH v9 10/15] dt-bindings: usb: mediatek,mtk-xhci: Switch to ports for USB connections

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: validation failure due to removed 'port' node
--

commit 40ec61fbce26b9243d28fee1a4cb89c268bd0a10
Author: Chen-Yu Tsai <wenst@chromium.org>

dt-bindings: usb: mediatek,mtk-xhci: Switch to ports for USB connections

This commit replaces the single port node with a ports sub-node for
describing USB connections in the MediaTek XHCI binding. It maps port 1 to
Super Speed and port 2 to High Speed, matching the hardware capabilities.

> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index 231e6f35a986f..d6c75bd20b785 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -107,10 +107,6 @@ properties:
>        - description: USB3/SS(P) PHY
>        - description: USB2/HS PHY
>  
> -  port:
> -    $ref: /schemas/graph.yaml#/properties/port
> -    description: Super Speed (SS) Output endpoint to a Type-C connector
> -

[Severity: Medium]
Will this cause dtbs_check to fail for existing in-tree users?

The mediatek,mtk-xhci binding removes the port property, but there are
still existing in-tree device trees that use it. For example, in
arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi under &xhci1:

	port {
		xhci_ss_ep: endpoint {
			remote-endpoint = <&typec_con_ss>;
		};
	};

Because the schema enforces additionalProperties: false, the presence of
the now-undocumented port node in the DTS causes a validation error when
running make dtbs_check on ARM64 MediaTek platforms.

Should the port property be kept as deprecated, or should the in-tree
users be updated at the same time?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916075745.3549953-1-wenst@chromium.org?part=10