Re: [PATCH v8 04/17] iio: adc: adi-axi-adc: Add support for CRC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] iio: adc: adi-axi-adc: missing CRC callbacks for AD485X and AD408X backends
--

commit f224f9607f0c702705dd0b16aa9e1c0051158452
Author: Janani Sunil <janani.sunil@analog.com>

iio: adc: adi-axi-adc: Add support for CRC

This commit adds support for enabling and disabling Cyclic Redundancy Check
(CRC) processing in the AXI ADC backend. CRC provides data integrity
verification for high-speed ADC data streams.

> diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c
> index fc7cc92b35f0a..8b7c45d51dbe8 100644
> --- a/drivers/iio/adc/adi-axi-adc.c
> +++ b/drivers/iio/adc/adi-axi-adc.c

[ ... ]

> @@ -644,6 +663,8 @@ static const struct iio_backend_ops adi_axi_adc_ops = {
>  	.num_lanes_set = axi_adc_num_lanes_set,
>  	.debugfs_reg_access = iio_backend_debugfs_ptr(axi_adc_reg_access),
>  	.debugfs_print_chan_status = iio_backend_debugfs_ptr(axi_adc_debugfs_print_chan_status),
> +	.crc_enable = axi_adc_crc_enable,
> +	.crc_disable = axi_adc_crc_disable,
>  };

[Severity: Medium]
Are these callbacks also needed in the adi_ad485x_ops and adi_ad408x_ops
structures?

The patch adds crc_enable and crc_disable to the generic adi_axi_adc_ops,
but omits them from the variant-specific ops structures like adi_ad485x_ops
and adi_ad408x_ops. 

Since the CRC enable bit is documented earlier in the patch as common to all
AXI ADC cores, omitting these callbacks might cause iio_backend_crc_enable()
to incorrectly return -EOPNOTSUPP for the AD485X and AD408X variants.

Would it be safer to wire these callbacks up for all backend variants that
share the ADI_AXI_ADC_CNTRL_3_CRC_EN_MASK bit?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-ad7768-driver-v8-0-27aa24db5225@analog.com?part=4