All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Linus Walleij <linusw@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: fotg210: fix USB_EHCI_HCD dependency
Date: Wed, 16 Sep 2026 13:43:45 +0200	[thread overview]
Message-ID: <20260916114358.195465-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

When EHCI is a loadable module, the fotg210 HCD code cannot
be built-in:

s390-linux-ld: drivers/usb/fotg210/fotg210-hcd.o: in function `fotg210_hcd_reset':
fotg210-hcd.c:(.text+0x102): undefined reference to `ehci_setup'

Fix this using the same type of dependency that is already
used for the USB host support.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/fotg210/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/fotg210/Kconfig b/drivers/usb/fotg210/Kconfig
index 2c6e76faac64..b7f0b78be7a3 100644
--- a/drivers/usb/fotg210/Kconfig
+++ b/drivers/usb/fotg210/Kconfig
@@ -16,7 +16,7 @@ if USB_FOTG210
 config USB_FOTG210_HCD
 	bool "Faraday FOTG210 USB Host Controller support"
 	depends on USB=y || USB=USB_FOTG210
-	depends on USB_EHCI_HCD
+	depends on USB_EHCI_HCD=y || USB_EHCI_HCD=USB_FOTG210
 	select USB_EHCI_DEVIANT_PORT_STATUS_REG
 	select USB_EHCI_PORT_RESET_HOOKS
 	select USB_EHCI_PORT_SPEED_HOOK
-- 
2.53.0


             reply	other threads:[~2026-09-16 11:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 11:43 Arnd Bergmann [this message]
2026-09-16 12:48 ` [PATCH] usb: fotg210: fix USB_EHCI_HCD dependency Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916114358.195465-1-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.