From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Maria Lisina <sekoohaka.sarisan@gmail.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] mfd: intel-lpss: Clean up and modernize DebugFS usage
Date: Wed, 16 Sep 2026 14:42:47 +0100 [thread overview]
Message-ID: <20260916134247.GT11487@google.com> (raw)
In-Reply-To: <aqp3FMncWrzR1adT@ashevche-desk.local>
On Wed, 16 Sep 2026, Andy Shevchenko wrote:
> On Wed, Sep 16, 2026 at 11:27:32AM +0100, Lee Jones wrote:
> > On Wed, 16 Sep 2026, Maria Lisina wrote:
> >
> > > The DebugFS API is designed to handle errors gracefully.
> > > Any explicit checking on return values is considered an anti-pattern.
> > >
> > > This patch removes unnecessary error checking and converts
> > > intel_lpss_debugfs_add() into a void function.
> > >
> > > While at it, this patch also clean ups legacy and deprecated usage
> > > of S_IRUGO macro and debugfs_remove_recursive() function.
>
> ...
>
> > Why continue if this returns an error?
>
> Because we don't care.
If you engage your Embedded mind, you will reel at the wasted cycles!
--
Lee Jones
next prev parent reply other threads:[~2026-09-16 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 22:13 [PATCH v5] mfd: intel-lpss: Clean up and modernize DebugFS usage Maria Lisina
2026-09-16 7:23 ` Andy Shevchenko
2026-09-16 7:25 ` Andy Shevchenko
2026-09-16 10:27 ` Lee Jones
2026-09-16 11:01 ` Andy Shevchenko
2026-09-16 13:42 ` Lee Jones [this message]
2026-09-16 15:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916134247.GT11487@google.com \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=sekoohaka.sarisan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.