From: Lee Jones <lee@kernel.org>
To: Thomas Tai <thomas.tai@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
David Heidelberg <david@ixit.cz>
Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org, stable@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: (subset) [PATCH v3 1/2] mfd: wcd934x: Fix NULL pointer dereference on IRQ probe deferral
Date: Wed, 16 Sep 2026 15:04:10 +0100 [thread overview]
Message-ID: <20260916140410.GB1605367@google.com> (raw)
In-Reply-To: <178956680898.1616494.3176016583638775540.b4-ty@b4>
On Wed, 16 Sep 2026, Lee Jones wrote:
> On Thu, 03 Sep 2026 17:21:42 +0200, David Heidelberg wrote:
> > ddata->dev is only assigned at the end of wcd934x_slim_probe(), but the
> > of_irq_get() error path has passed it to the error print since the
> > driver was added, while it is still NULL.
> >
> > This used to be harmless with dev_err(), which copes with a NULL device
> > and was skipped on -EPROBE_DEFER. Since the switch to dev_err_probe(), a
> > deferred IRQ reaches device_set_deferred_probe_reason() ->
> > dev_driver_string(), which dereferences the NULL pointer and crashes
> > during probe. Use dev, which is already valid at this point.
> >
> > [...]
>
> Applied, thanks!
>
> [1/2] mfd: wcd934x: Fix NULL pointer dereference on IRQ probe deferral
> commit: 1389a4a5877403e57573d6bc01c5b7790a4472ce
Didn't apply initially, but I reworked it.
--
Lee Jones
next prev parent reply other threads:[~2026-09-16 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 15:21 [PATCH v3 0/2] wcd934x fixes David Heidelberg via B4 Relay
2026-09-03 15:21 ` David Heidelberg
2026-09-03 15:21 ` [PATCH v3 1/2] mfd: wcd934x: Fix NULL pointer dereference on IRQ probe deferral David Heidelberg via B4 Relay
2026-09-03 15:21 ` David Heidelberg
2026-09-16 13:53 ` (subset) " Lee Jones
2026-09-16 14:04 ` Lee Jones [this message]
2026-09-03 15:21 ` [PATCH v3 2/2] mfd: wcd934x: Set DMA mask on parent to silence "DMA mask not set" David Heidelberg via B4 Relay
2026-09-03 15:21 ` David Heidelberg
2026-09-16 13:49 ` Lee Jones
2026-09-16 13:53 ` [PATCH v3 0/2] wcd934x fixes Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916140410.GB1605367@google.com \
--to=lee@kernel.org \
--cc=david@ixit.cz \
--cc=konrad.wilk@oracle.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=phone-devel@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.tai@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.