Re: [PATCH v6 06/11] iio: dac: mcp47feb02: Avoid unjustified probe error on missing label

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] iio: dac: spurious warning logged for missing optional label
--

commit e24a38fff253c54913e6b4136af8560e0bb6d2da
Author: Ariana Lazar <ariana.lazar@microchip.com>

iio: dac: mcp47feb02: Avoid unjustified probe error on missing label

This commit resolves an unjustified probe error when the optional 'label'
property is missing by substituting dev_err_probe() with dev_warn_probe().
It also corrects %pfw usage and safely handles null label reads.

Link: https://lore.kernel.org/all/20260804134616.1D8A21F00A3E@smtp.kernel.org/

> diff --git a/drivers/iio/dac/mcp47feb02.c b/drivers/iio/dac/mcp47feb02.c
> index a93e05cda5f36..67bf8d9d98350 100644
> --- a/drivers/iio/dac/mcp47feb02.c
> +++ b/drivers/iio/dac/mcp47feb02.c
[ ... ]
> @@ -977,8 +980,7 @@ static int mcp47feb02_parse_fw(struct iio_dev *indio_dev,
>  
>  		ret = fwnode_property_read_string(child, "label", &data->labels[reg]);
>  		if (ret)
> -			return dev_err_probe(dev, ret, "%pfw: invalid label\n",
> -					     fwnode_get_name(child));
> +			dev_warn_probe(dev, ret, "%pfw: invalid label\n", child);

[Severity: Medium]
Since the commit message indicates the 'label' property is optional, does
this code unintentionally cause log spam for valid configurations?

When the label is not present in the devicetree,
fwnode_property_read_string() will return an error. Because this code
checks if (ret) and calls dev_warn_probe() unconditionally, a warning will
be logged on every boot even when the missing label is a valid setup.

Looking at the rest of the patch series, it does not appear that this
warning behavior is updated in subsequent patches like mcp47feb02-core.c.

Is there a way to verify the exact error code or avoid the warning entirely
when the property is simply absent?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-mcp47feb02_refactor-v6-0-285464651f89@microchip.com?part=6