From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org
Subject: Re: [PATCH iwl-next 2/4] ixgbe: add ixgbe_container_is_rx() helper and refine RX adaptive ITR
Date: Wed, 16 Sep 2026 15:41:40 +0100 [thread overview]
Message-ID: <20260916144140.GN51261@horms.kernel.org> (raw)
In-Reply-To: <20260915125538.3975870-3-aleksandr.loktionov@intel.com>
On Tue, Sep 15, 2026 at 02:55:36PM +0200, Aleksandr Loktionov wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> Add an ixgbe_container_is_rx() helper to cleanly distinguish RX from TX
> ring containers inside ixgbe_update_itr().
>
> Refine the RX-specific latency-detection path:
>
> - Replace the shared "packets < 4 or bytes < 9000" threshold with an
> RX-specific check of "1..23 packets and bytes < 12112". When that
> condition holds, target 8x the observed byte count in the next
> interval by computing avg_wire_size = (bytes + packets * 24) * 2,
> clamped to [2560, 12800], and jumping directly to the speed-based
> ITR calculation. This provides finer-grained control over low-rate
> RX latency workloads without affecting TX.
>
> - Remove the separate "no packets" special-case block. When packets
> is 0 it falls into the "< 48" branch. The mode-tracking logic in
> that branch is extended: fewer than 8 packets forces latency mode;
> 8..47 packets preserves the current mode. This replaces the old
> unconditional "add LATENCY flag from ring_container->itr" carried
> over from the removed block.
>
> - Remove the adjust_by_size label and the associated "halve
> avg_wire_size in latency mode" step. The Rx latency path now
> pre-calculates avg_wire_size independently and the bulk path no
> longer needs the halving to compensate for incorrect thresholds.
> Rename the jump target to adjust_for_speed to reflect its purpose.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-09-16 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 12:55 [PATCH iwl-next 0/4] ixgbe: adaptive ITR tuning to prevent RX starvation and ACK overdrive Aleksandr Loktionov
2026-09-15 12:55 ` [PATCH iwl-next 1/4] ixgbe: lower IXGBE_ITR_ADAPTIVE_MAX_USECS to prevent RX starvation Aleksandr Loktionov
2026-09-16 14:41 ` Simon Horman
2026-09-15 12:55 ` [PATCH iwl-next 2/4] ixgbe: add ixgbe_container_is_rx() helper and refine RX adaptive ITR Aleksandr Loktionov
2026-09-16 14:41 ` Simon Horman [this message]
2026-09-15 12:55 ` [PATCH iwl-next 3/4] ixgbe: limit ITR decrease in latency mode to prevent ACK overdrive Aleksandr Loktionov
2026-09-15 12:55 ` [PATCH iwl-next 4/4] ixgbe: add IXGBE_ITR_ADAPTIVE_MASK_USECS constant Aleksandr Loktionov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916144140.GN51261@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.