Re: [PATCH v2 2/2] leds: flash: Simplify flash_fault_show()

[Lee Jones <lee@kernel.org>]

On Fri, 04 Sep 2026, Dmitry Antipov wrote:

> Do not emit extra trailing space and prefer direct pointer
> ops over strcat() and strlen() calls in flash_fault_show().
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> v2: capitalize commit title
> ---
>  drivers/leds/led-class-flash.c | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
> index 3bb90823de1a..d09c71fcd2b3 100644
> --- a/drivers/leds/led-class-flash.c
> +++ b/drivers/leds/led-class-flash.c
> @@ -189,24 +189,22 @@ static ssize_t flash_fault_show(struct device *dev,
>  	struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
>  	u32 fault = 0, mask = 0x1;
>  	char *pbuf = buf;
> -	int i, ret, buf_len;
> +	int i, ret;
>  
>  	ret = led_get_flash_fault(fled_cdev, &fault);
>  	if (ret < 0)
>  		return -EINVAL;
>  
> -	*buf = '\0';
> -
>  	for (i = 0; i < LED_NUM_FLASH_FAULTS; ++i) {
> -		if (fault & mask) {
> -			buf_len = sprintf(pbuf, "%s ",
> -					  led_flash_fault_names[i]);
> -			pbuf += buf_len;
> -		}
> +		if (fault & mask)
> +			pbuf += sprintf(pbuf, "%s%s",
> +					(pbuf == buf ? "" : " "),
> +					led_flash_fault_names[i]);

Shouldn't this be sysfs_emit_at() now?

>  		mask <<= 1;
>  	}
> -
> -	return strlen(strcat(buf, "\n"));
> +	*pbuf++ = '\n';
> +	*pbuf = '\0';
> +	return pbuf - buf;
>  }

sysfs_emit_at() would also avoid some of this dancing around, I think.

>  static DEVICE_ATTR_RO(flash_fault);
>  
> -- 
> 2.55.0
> 
> 

-- 
Lee Jones