Re: [PATCH v3 2/4] dmaengine: loongson: use named initializers for acpi_device_id

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dmaengine: loongson: incomplete unification of list terminators
--

commit 4321a78607f15fa601095e26975f8fbd9cdea572
Author: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>

dmaengine: loongson: use named initializers for acpi_device_id

Use a named initializer for the acpi_device_id fields which makes the code
more readable and consistent with how lists are initialized in the rest of
the kernel code base.

Unify the list terminator to have a single space between the brackets and
no trailing comma.

> diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> index 1c9a542edc859..70880625c6e92 100644
> --- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> +++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> @@ -709,8 +709,8 @@ static const struct of_device_id loongson2_cmc_dma_of_match[] = {
>  MODULE_DEVICE_TABLE(of, loongson2_cmc_dma_of_match);
>  
>  static const struct acpi_device_id loongson2_cmc_dma_acpi_match[] = {
> -	{ "LOON0014", .driver_data = (kernel_ulong_t)&ls2k3000_cmc_dma_config },
> -	{ /* sentinel */ }
> +	{ .id = "LOON0014", .driver_data = (kernel_ulong_t)&ls2k3000_cmc_dma_config },
> +	{ }

[Severity: Low]
The commit message mentions unifying the list terminator, but does this miss
the OF match table located immediately above?

drivers/dma/loongson/loongson2-apb-cmc-dma.c:
static const struct of_device_id loongson2_cmc_dma_of_match[] = {
	...
	{ .compatible = "loongson,ls2k3000-dma", .data = &ls2k3000_cmc_dma_config },
	{ /* sentinel */ }
};

Should the list terminator here also be updated for consistency?

>  };
>  MODULE_DEVICE_TABLE(acpi, loongson2_cmc_dma_acpi_match);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-acpi-dma-v3-0-0dac05654967@thegoodpenguin.co.uk?part=2