From: sashiko-bot@kernel.org
To: "Tianyi Chen" <hi@tychen.cc>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf sched stats: Reject mismatched or incomplete snapshots
Date: Wed, 16 Sep 2026 16:23:05 +0000 [thread overview]
Message-ID: <20260916162306.125FF1F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260916161125.2548499-1-hi@tychen.cc>
> The before and after records are paired by list position. If a CPU or
> domain disappears, counters can be subtracted from a different record
> or left as absolute values. An extra record can also advance the cursor
> past the list.
>
> Identify the second snapshot by its timestamp or CPU ordering, and
> require matching CPU/domain IDs and versions before subtracting. Check
> that every record has a counterpart before printing, and propagate
> errors from either input of diff.
>
> Add a shell test with synthetic snapshots, including equal timestamps,
> CPU filtering, and missing or reordered CPU/domain records.
>
> Fixes: 5a357ae6ad63 ("perf sched stats: Add support for report subcommand")
> Assisted-by: LLM
> Signed-off-by: Tianyi Chen <hi@tychen.cc>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916161125.2548499-1-hi@tychen.cc?part=1
next prev parent reply other threads:[~2026-09-16 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 16:11 [PATCH] perf sched stats: Reject mismatched or incomplete snapshots Tianyi Chen
2026-09-16 16:23 ` sashiko-bot [this message]
2026-09-25 13:07 ` Arnaldo Carvalho de Melo
2026-09-28 13:27 ` Swapnil Sapkal
2026-09-30 18:06 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916162306.125FF1F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=hi@tychen.cc \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.