Re: [PATCH v10 28/38] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] macro: redefinition of _DPRINTK_CLASSBITS_INIT
--

commit 0781b4eba8375be337f6f650796b2d759c24bf73
Author: Jim Cromie <jim.cromie@gmail.com>

dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API

This commit moves the DYNAMIC_DEBUG_CLASSMAP_PARAM macro into the header
and refines it into two separate macros for different use cases. It also adds
stub macros for !CONFIG_DYNAMIC_DEBUG and cleans up the test code.

> diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
> index 26c858588eb16..3114f4f28be44 100644
> --- a/include/linux/dynamic_debug.h
> +++ b/include/linux/dynamic_debug.h
> @@ -60,6 +60,8 @@ struct _ddebug {
>  #else
>  #define _DPRINTK_FLAGS_DEFAULT 0
>  #endif
> +#define _DPRINTK_CLASSBITS_INIT ((_DPRINTK_FLAGS_DEFAULT & _DPRINTK_FLAGS_PRINT) ? ~0U : 0U)
> +
>  	unsigned int flags:8;
>  #ifdef CONFIG_JUMP_LABEL
>  	union {

[ ... ]

> @@ -466,9 +506,20 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
>  #include <linux/errno.h>
>  #include <linux/printk.h>
>  
> +#if defined(DEBUG)
> +#define _DPRINTK_CLASSBITS_INIT ~0U
> +#else
> +#define _DPRINTK_CLASSBITS_INIT 0U
> +#endif

[Severity: Low]
Does this redefine _DPRINTK_CLASSBITS_INIT when CONFIG_DYNAMIC_DEBUG is
disabled? The macro is already defined unconditionally earlier in this file
(just before the flags field of struct _ddebug), which causes a
-Wmacro-redefined compiler warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-dd-cmap-part2-clean-v10-0-af4cf4767707@gmail.com?part=28