All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Thomas Falcon" <thomas.falcon@intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v10 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf()
Date: Wed, 16 Sep 2026 16:41:19 +0000	[thread overview]
Message-ID: <20260916164120.492551F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260916163127.318885-2-thomas.falcon@intel.com>

> When printing memory info in perf script, the entire size of the
> buffer is passed to perf_mem__lvl_scnprintf() instead of the remaining
> size. Pass the remaining buffer size instead.
> 
> This issue was detected by sashiko during an internal code review.
> 
> Assisted-by: Sashiko:gemini-3.1-pro-preview
> Fixes: fdefc3750e847 ("perf mem: Print memory operation type")
> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Reviewed-by: Ian Rogers <irogers@google.com>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916163127.318885-1-thomas.falcon@intel.com?part=1


  reply	other threads:[~2026-09-16 16:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 16:31 [PATCH v10 0/6] perf: Add support for memory region/range reporting Thomas Falcon
2026-09-16 16:31 ` [PATCH v10 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf() Thomas Falcon
2026-09-16 16:41   ` sashiko-bot [this message]
2026-09-16 16:31 ` [PATCH v10 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0 Thomas Falcon
2026-09-16 16:46   ` sashiko-bot
2026-09-16 16:31 ` [PATCH v10 3/6] perf header: Support memory ranges Thomas Falcon
2026-09-16 16:45   ` sashiko-bot
2026-09-16 16:31 ` [PATCH v10 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
2026-09-16 16:42   ` sashiko-bot
2026-09-17  6:04   ` Mi, Dapeng
2026-09-17 17:37     ` Falcon, Thomas
2026-09-18  1:01       ` Mi, Dapeng
2026-09-16 16:31 ` [PATCH v10 5/6] perf tools: Show memory region in perf-script subcommand Thomas Falcon
2026-09-16 16:50   ` sashiko-bot
2026-09-16 16:31 ` [PATCH v10 6/6] perf c2c: print memory region data with stdio output Thomas Falcon
2026-09-16 16:48   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916164120.492551F00898@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=thomas.falcon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.