All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jeremy Bongio" <jbongio@google.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/irdma: Use kvzalloc for lvl2 leafmem allocation
Date: Wed, 16 Sep 2026 17:42:13 +0000	[thread overview]
Message-ID: <20260916174213.832221F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916173203.2555458-1-jbongio@google.com>

> During VM live migration or when registering large memory regions
> (e.g., guest memory >= 256 GB backed by 4 KiB pages), get_lvl2_pble()
> calculates total leaves exceeding ~131,072. The memory required for
> lvl2->leafmem.va exceeds 4 MiB (sizeof(*leaf) * total > 5.24 MiB).
> 
> Because kzalloc() requires physically contiguous pages, requests larger
> than MAX_PAGE_ORDER (4 MiB on x86_64) fail and trigger a warning:
> 
>   WARNING: CPU: 123 PID: 119906 at mm/page_alloc.c:5997 __alloc_frozen_pages_noprof+0x50c/0x1050
>   Call Trace:
>    <TASK>
>    alloc_frozen_pages_noprof+0xc0/0x240
>    ___kmalloc_large_node+0x3d/0xd0
>    __kmalloc_large_node_noprof+0x1b/0x90
>    __kmalloc_noprof+0x254/0x660
> [ ... ]
> virtually contiguous memory via vmalloc.
> 
> Fixes: e8c4dbc2fcac ("RDMA/irdma: Add PBLE resource manager")
> Assisted-by: LLM
> Signed-off-by: Jeremy Bongio <jbongio@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916173203.2555458-1-jbongio@google.com?part=1


  reply	other threads:[~2026-09-16 17:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 17:32 [PATCH] RDMA/irdma: Use kvzalloc for lvl2 leafmem allocation Jeremy Bongio
2026-09-16 17:42 ` sashiko-bot [this message]
2026-09-16 18:32   ` Jacob Moroni
2026-09-22 14:16 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916174213.832221F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=jbongio@google.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.