Re: [PATCH 03/12] perf config: Move perf_config__set_variable() to util/config.c

[sashiko-bot@kernel.org]

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> It is code from the 'perf config' builtin to set a variable in the
> configuration file perf is using, the user's ~/.perfconfig, or the file
> named by the PERF_CONFIG environment variable when it is set, rewriting
> that file from the config set, the same rewrite 'perf config' does,
> i.e. the comments in it are not preserved, as the config set carries
> just the key-value pairs.  It has to honour PERF_CONFIG, that makes perf
> read only that file: the config set is loaded from it, so writing
> ~/.perfconfig would replace it with the exclusive file's entries.
> 
> The next patch wants to use it from util/debuginfo.c, so that when the
> user asks for a debuginfod fetch to be skipped, pressing 'd', the
> disable can also be made permanent, moving perf_config__set_variable()
> to util/config.c, together with the set_config() body it uses,
> parameterized as perf_config_set__write() with the system_config
> choice as an argument, since the builtin's static use_system_config
> and use_user_config option variables are not available outside it.
> 'perf config' keeps its behavior via the set_config() wrapper.
> 
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916183215.54305-1-acme@kernel.org?part=3