Re: [PATCH] dt-bindings: axis-fifo: Added missing binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: axis-fifo: typo in compatible string causes schema validation failure
- [Low] dt-bindings: axis-fifo: duplicate binding due to undeleted text file
--

commit 568433c34dce8d35f577a763a1632c2b7df8dc0b
Author: Daniel Matyas <matyasdaniel005@gmail.com>

dt-bindings: axis-fifo: Added missing binding
    
drivers/staging/axis-fifo/axis-fifo.txt file described how the
devicetree of the driver should look like. Convert it to .yaml file.
Issue found by checkpatch.

> drivers/staging/axis-fifo/axis-fifo.txt file described how the
> devicetree of the driver should look like. Convert it to .yaml file.

[Severity: Low]
Does this commit leave a duplicate binding in the tree?

The commit message mentions converting the axis-fifo.txt file to .yaml,
but the patch does not appear to delete drivers/staging/axis-fifo/axis-fifo.txt.

> diff --git a/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
> new file mode 100644
> index 0000000000000..ef1e6bcf782d7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - xlnx,axis-fifo-mm-s-4.1
> +      - xlnx,axis-fifo-mm-s-4.2
> +      - xlnx,axis-fifo-mm-s-4.3

[Severity: Low]
Are these compatible strings misspelled?

The enum defines xlnx,axis-fifo-mm-s-4.1 with an 's' in axis, but the
actual compatible string used by the driver, existing device trees, and the
provided YAML example is xlnx,axi-fifo-mm-s-4.1 without the 's'. This
could cause a schema validation regression.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916201253.483877-1-matyasdaniel005@gmail.com?part=1