From: greearb@candelatech.com
To: linux-wireless@vger.kernel.org
Cc: Ben Greear <greearb@candelatech.com>
Subject: [RFC 1/2] wifi: mt76: disable NAPI before deleting in dma_cleanup
Date: Wed, 16 Sep 2026 13:47:49 -0700 [thread overview]
Message-ID: <20260916204750.1439984-1-greearb@candelatech.com> (raw)
From: Ben Greear <greearb@candelatech.com>
NAPI should be disabled before deleted, this stops
a warning seen when trying to rmmod mt7996e.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
NOTE: Seems to be regression between 6.18 and 7.2, haven't looked
closer yet.
drivers/net/wireless/mediatek/mt76/dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c
index a67880a9281c..6de3f28219bc 100644
--- a/drivers/net/wireless/mediatek/mt76/dma.c
+++ b/drivers/net/wireless/mediatek/mt76/dma.c
@@ -1217,6 +1217,7 @@ void mt76_dma_cleanup(struct mt76_dev *dev)
mt76_for_each_q_rx(dev, i) {
struct mt76_queue *q = &dev->q_rx[i];
+ napi_disable(&dev->napi[i]);
netif_napi_del(&dev->napi[i]);
mt76_dma_rx_cleanup(dev, q);
--
2.42.0
next reply other threads:[~2026-09-16 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 20:47 greearb [this message]
2026-09-16 20:47 ` [RFC 2/2] wifi: mt76: mt7996: Clean up IRQ on module unload greearb
2026-09-18 11:04 ` [RFC 1/2] wifi: mt76: disable NAPI before deleting in dma_cleanup Shiji Yang
2026-09-18 15:22 ` Ben Greear
2026-09-20 3:49 ` Devin Wittmayer
2026-09-20 14:49 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916204750.1439984-1-greearb@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.