Re: [PATCH 1/3] drm/xe/guc: Add simple KLV decoder helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] doc: mismatched kernel-doc parameters for xe_guc_klv_decode_string()
--

commit 00a2cb03138e3f97464e63d20cf077884ec27126
Author: Michal Wajdeczko <michal.wajdeczko@intel.com>

drm/xe/guc: Add simple KLV decoder helpers

This commit adds simple helpers to decode data from KLV dwords instead of
retrieving them manually, along with sanity checks.

> diff --git a/drivers/gpu/drm/xe/xe_guc_klv_helpers.c b/drivers/gpu/drm/xe/xe_guc_klv_helpers.c
> index dc8612d761e3c..5c40ee44d9a56 100644
> --- a/drivers/gpu/drm/xe/xe_guc_klv_helpers.c
> +++ b/drivers/gpu/drm/xe/xe_guc_klv_helpers.c
[ ... ]
> @@ -372,6 +372,85 @@ int xe_guc_klv_parser(const u32 *klvs, u32 num_dwords, void *obj,
[ ... ]
> +/**
> + * xe_guc_klv_decode_string() - Decode string data from KLV.
> + * @key: the key
> + * @len: number of dwords in @value
> + * @value: array of dwords
> + * @data: pointer where to store the data
> + *
> + * Note: caller must use kfree() to release decoded string.
> + *
> + * Return: 0 on success or a negative error code on failure.
> + */
> +int xe_guc_klv_decode_string(const u32 *value, u16 len, char **data)

[Severity: Low]
This isn't a bug, but there is a mismatch in the kernel-doc for
xe_guc_klv_decode_string().

The @key parameter is documented but does not exist in the function
signature. Additionally, the order of @len and @value in the comment differs
from the signature.

Could this be updated to match the signature and avoid W=1 build warnings?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916215827.13488-1-michal.wajdeczko@intel.com?part=1