From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: Frank.Li@kernel.org, dmaengine@vger.kernel.org, vkoul@kernel.org
Subject: Re: [PATCH] dmaengine: ste_dma40: allow COMPILE_TEST
Date: Wed, 16 Sep 2026 23:00:25 +0000 [thread overview]
Message-ID: <20260916230025.671171F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916225241.280606-1-rosenp@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: STE_DMA40 missing HAS_IOMEM dependency for COMPILE_TEST
--
commit f5b43b7cb15b71f44f87940150c9d52817cad404
Author: Rosen Penev <rosenp@gmail.com>
dmaengine: ste_dma40: allow COMPILE_TEST
This commit loosens the Kconfig dependencies for STE_DMA40 to allow building
on other architectures via COMPILE_TEST. It aims to increase compile coverage
by exposing the driver to more build configurations.
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index ae6a682c9f769..f16bd4059d84a 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -559,7 +559,7 @@ config SOPHGO_CV1800B_DMAMUX
>
> config STE_DMA40
> bool "ST-Ericsson DMA40 support"
> - depends on ARCH_U8500
> + depends on ARCH_U8500 || COMPILE_TEST
> select DMA_ENGINE
> select SRAM
[Severity: Low]
Does this also need a dependency on HAS_IOMEM?
By allowing COMPILE_TEST in drivers/dma/Kconfig for STE_DMA40 and keeping the
select for SRAM, architectures without HAS_IOMEM (like User-Mode Linux or
some s390 configurations) will trigger unmet dependency build warnings for
SRAM when COMPILE_TEST is enabled.
This can also lead to compilation failures on those architectures due to
missing I/O memory accessors like readl or writel that SRAM might depend on.
Could this be resolved by making STE_DMA40 depend on HAS_IOMEM?
> help
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916225241.280606-1-rosenp@gmail.com?part=1
next prev parent reply other threads:[~2026-09-16 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 22:52 [PATCH] dmaengine: ste_dma40: allow COMPILE_TEST Rosen Penev
2026-09-16 23:00 ` sashiko-bot [this message]
2026-09-17 3:17 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916230025.671171F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.