All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: SJ Park <sj@kernel.org>
Cc: Donggeun Yoo <donggeunyoo.kernel@gmail.com>,
	akpm@linux-foundation.org, damon@lists.linux.dev,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] mm/damon/core: charge only the part of a region the filter left
Date: Thu, 17 Sep 2026 10:38:36 +0900	[thread overview]
Message-ID: <20260917013836.100213-1-donggeunyoo.kernel@gmail.com> (raw)
In-Reply-To: <20260917012420.101087-1-sj@kernel.org>

On Wed, 16 Sep 2026 18:24:19 -0700, SJ Park wrote:
> The user impact is that DAMOS could work unexpectedly slow, due to
> over-charged quota.  Also DAMOS stat could be confusing.  No critical
> events such as crashes or leask happen.
>
> If above is not incorrect, I will add that to the commit message when I
> add this patch to damon/next tree.

That is correct, please add it.

The stale size is only ever arithmetic: damos_charge_quota() and
damos_update_stat() take it, and nothing dereferences or frees against
it, so there is no memory-safety consequence.

Thanks for the review.


  reply	other threads:[~2026-09-17  1:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  0:35 [PATCH v1 0/2] mm/damon/core: fix the size charged for a filter-trimmed region Donggeun Yoo
2026-09-17  0:35 ` [PATCH v1 1/2] mm/damon/core: charge only the part of a region the filter left Donggeun Yoo
2026-09-17  0:43   ` sashiko-bot
2026-09-17  1:24   ` SJ Park
2026-09-17  1:38     ` Donggeun Yoo [this message]
2026-09-17  0:35 ` [PATCH v1 2/2] mm/damon/tests/core-kunit: test the size charged for a filter-trimmed region Donggeun Yoo
2026-09-17  0:42   ` sashiko-bot
2026-09-17  1:26   ` SJ Park
2026-09-17  1:28 ` [PATCH v1 0/2] mm/damon/core: fix " SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917013836.100213-1-donggeunyoo.kernel@gmail.com \
    --to=donggeunyoo.kernel@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.