From: sashiko-bot@kernel.org
To: "Dapeng Mi" <dapeng1.mi@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 01/12] perf/x86/intel: Fix GRT PEBS load/store direction for latency events
Date: Thu, 17 Sep 2026 02:14:12 +0000 [thread overview]
Message-ID: <20260917021413.399F21F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260917015234.981153-2-dapeng1.mi@linux.intel.com>
> On Gracemont, intel_grt_pebs_event_constraints[] applies LAT_CONSTRAINT
> constraints to MEM_UOPS_RETIRED.{LOAD,STORE}_LATENCY, but does not set
> explicit LOAD/STORE flags for those events.
>
> The PEBS latency path (pebs_latency_data(), via __grt_latency_data())
> uses the event flags to determine memory operation direction. Without an
> explicit STORE flag, samples from MEM_UOPS_RETIRED.STORE_LATENCY can be
> misclassified as LOADs.
>
> Set explicit LOAD/STORE flags in intel_grt_pebs_event_constraints[] for:
> - MEM_UOPS_RETIRED.LOAD_LATENCY
> - MEM_UOPS_RETIRED.STORE_LATENCY
>
> Also update __grt_latency_data() to explicitly interpret these flags when
> assigning the sampled memory operation direction.
>
> This fixes incorrect STORE sample classification.
>
> Fixes: 39a41278f041 ("perf/x86/intel: Fix PEBS memory access info encoding for ADL")
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917015234.981153-1-dapeng1.mi@linux.intel.com?part=1
next prev parent reply other threads:[~2026-09-17 2:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 1:52 [PATCH 00/12] perf/x86/intel: PEBS data-source fixes and OMR updates Dapeng Mi
2026-09-17 1:52 ` [PATCH 01/12] perf/x86/intel: Fix GRT PEBS load/store direction for latency events Dapeng Mi
2026-09-17 2:14 ` sashiko-bot [this message]
2026-09-17 1:52 ` [PATCH 02/12] perf/x86/intel: Fix CMT " Dapeng Mi
2026-09-17 2:08 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 03/12] perf/x86/intel: Fix DKT " Dapeng Mi
2026-09-17 2:09 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 04/12] perf/x86/intel: Update arw_latency_data() mem-op direction handling Dapeng Mi
2026-09-17 2:21 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 05/12] perf/x86/intel: Remove incorrect LionCove PEBS data-source constraints Dapeng Mi
2026-09-17 2:10 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 06/12] perf/x86/intel: Remove incorrect PantherCove " Dapeng Mi
2026-09-17 2:10 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 07/12] perf/x86/intel: Correct Panther cove data source snoop states Dapeng Mi
2026-09-17 2:05 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 08/12] perf/x86/intel: Delete dead NVL PEBS data-source init call Dapeng Mi
2026-09-17 2:11 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 09/12] perf/x86/intel: Constrain PantherCove UOPS_DISPATCHED events Dapeng Mi
2026-09-17 2:03 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 10/12] perf/x86/intel: Add precise OMR event support for DMR/NVL Dapeng Mi
2026-09-17 2:11 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 11/12] perf/x86/intel: Rename DMR offcore_rsp attribute to offmodule_rsp Dapeng Mi
2026-09-17 2:11 ` sashiko-bot
2026-09-17 1:52 ` [PATCH 12/12] perf/x86/intel: Rename NVL " Dapeng Mi
2026-09-17 2:14 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917021413.399F21F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dapeng1.mi@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.