From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v2 05/10] mm/damon/core: document damon_call()/damon_start() race hang issue
Date: Wed, 16 Sep 2026 21:05:31 -0700 [thread overview]
Message-ID: <20260917040537.107341-6-sj@kernel.org> (raw)
In-Reply-To: <20260917040537.107341-1-sj@kernel.org>
Let's suppose damon_start() and damon_call() are executed in parallel
for the same DAMON context. Then, damon_call() could show
ctx->damon_calls_obsolete set while ctx->kdamond is unset. If
damon_start() sets ctx->kdamond before damon_call() starts the
cancelling, damon_call() can indefinitely hang. No DAMON API caller
does such parallel execution of damon_start() and damon_call(), so the
issue doesn't exist. But who knows what will happen in future. Add a
clarification comment for caution.
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 9120a1b707b24..4687b909d42c9 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2258,6 +2258,9 @@ int damon_kdamond_pid(struct damon_ctx *ctx)
*
* When this function is failed, the @ctx is guaranteed to be stopped.
*
+ * This function should not be called in parallel to damon_start() for the
+ * @ctx. In the case, this function could indefinitely hang.
+ *
* Return: 0 on success, negative error code otherwise.
*/
int damon_call(struct damon_ctx *ctx, struct damon_call_control *control)
--
2.47.3
next prev parent reply other threads:[~2026-09-17 4:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 4:05 [RFC PATCH v2 00/10] mm/damon: improve readability, clarity and test coverage SJ Park
2026-09-17 4:05 ` [RFC PATCH v2 01/10] mm/damon/api: remove NR_DAMOS_FILTER_TYPES SJ Park
2026-09-17 4:09 ` sashiko-bot
2026-09-17 4:05 ` [RFC PATCH v2 02/10] mm/damon/core: use abs_diff() in damon_feed_loop_next_input() SJ Park
2026-09-17 4:09 ` sashiko-bot
2026-09-17 4:05 ` [RFC PATCH v2 03/10] mm/damon/core: use mult_frac() " SJ Park
2026-09-17 4:09 ` sashiko-bot
2026-09-17 4:05 ` [RFC PATCH v2 04/10] mm/damon/core: set damon_ctx->walk_control_obsolete in damon_new_ctx() SJ Park
2026-09-17 4:13 ` sashiko-bot
2026-09-17 4:05 ` SJ Park [this message]
2026-09-17 4:13 ` [RFC PATCH v2 05/10] mm/damon/core: document damon_call()/damon_start() race hang issue sashiko-bot
2026-09-17 4:05 ` [RFC PATCH v2 06/10] mm/damon/paddr: remove pa parameter from damon_pa_filter_pass() SJ Park
2026-09-17 4:08 ` sashiko-bot
2026-09-17 4:05 ` [RFC PATCH v2 07/10] mm/damon/tests/core-kunit: test eligible_mem_bp commitment SJ Park
2026-09-17 4:11 ` sashiko-bot
2026-09-17 4:05 ` [RFC PATCH v2 08/10] mm/damon/tests/core-kunit: add probe_hits_wsum damos filter commit test SJ Park
2026-09-17 4:09 ` sashiko-bot
2026-09-17 4:05 ` [RFC PATCH v2 09/10] selftests/damon/sysfs_memcg_path_leak: fail only for real DAMON leak SJ Park
2026-09-17 4:13 ` sashiko-bot
2026-09-17 4:05 ` [RFC PATCH v2 10/10] Docs/mm/damon/design: clarify bp is basis point SJ Park
2026-09-17 4:09 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917040537.107341-6-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.