All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chenguang Zhao <chenguang.zhao@linux.dev>
To: Andrew Lunn <andrew@lunn.ch>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, Chenguang Zhao <zhaochenguang@kylinos.cn>,
	syzbot+694b49f41098a5df4fd7@syzkaller.appspotmail.com
Subject: Re: [PATCH net] net: phy: allow phy_detach() before netdev registration
Date: Thu, 17 Sep 2026 15:06:46 +0800	[thread overview]
Message-ID: <20260917070559.GA85254@pc> (raw)
In-Reply-To: <d523dec3-7075-47d9-8ac2-6b3c9d6cec3d@lunn.ch>

On Wed, Sep 16, 2026 at 02:12:27PM +0200, Andrew Lunn wrote:
> On Wed, Sep 16, 2026 at 10:15:05AM +0800, Chenguang Zhao wrote:
> > From: Chenguang Zhao <zhaochenguang@kylinos.cn>
> > 
> > phylink_connect_phy() may be called from probe without RTNL while the
> > net_device is still NETREG_UNINITIALIZED. If PHY bring-up fails,
> > phy_detach() uses rtnl_dereference(dev->hwprov) and lockdep reports
> > suspicious RCU usage.
> 
> What do you mean by PHY bring-up?
> 
>      Andrew
Hi Andrew

PHY bring-up refers to phylink_bringup_phy(). The call chain is as follows:

usbnet_probe
  -> ax88772_bind
       -> ax88772_init_phy
            -> phylink_connect_phy
                 -> phylink_attach_phy / phy_attach_direct   // suceess 
                 -> phylink_bringup_phy                      // fail 
                 -> phy_detach                               // No RTNL
                      -> rtnl_dereference(dev->hwprov)       // lockdep warning

Because RTNL is not held when phy_detach() is called, rtnl_dereference() triggers a lockdep warning.

Thanks
Chenguang

  reply	other threads:[~2026-09-17  7:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  2:15 [PATCH net] net: phy: allow phy_detach() before netdev registration Chenguang Zhao
2026-09-16 12:12 ` Andrew Lunn
2026-09-17  7:06   ` Chenguang Zhao [this message]
2026-09-17 12:04     ` Andrew Lunn
2026-09-21  2:03       ` Chenguang Zhao
2026-09-21 12:15         ` Andrew Lunn
2026-09-23  7:16           ` Chenguang Zhao
2026-09-20  2:32 ` netdev-bot+sashiko
2026-09-21  2:09   ` Chenguang Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917070559.GA85254@pc \
    --to=chenguang.zhao@linux.dev \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+694b49f41098a5df4fd7@syzkaller.appspotmail.com \
    --cc=zhaochenguang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.