From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDD14C88E72 for ; Thu, 17 Sep 2026 10:39:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gHtOYP93bVthwybu3jQBcNROjajACu09lptcOcoX0CQ=; b=xB/KPOkN+FwSjq /ZSkTWhQKg5OBowK8e8hjGI1G9icczZM979rQnlcadgeduboNR/16KwxNbAfp/SjRzu1zBNzycumr 8j+7LO4M3YjSaDci5OKeytDwSEvYvCZuHeyECUTrzDRIAn14H2nEZPtYuhgp/UwNWzVhvS/iaZHIt tornR0eU9rCC14/bkl79NHRt+qmQtZ752ddBO3qvz319KwqXhRIor7NAq7ngQoNBfMVjrdohRplv9 4786QhmJ7Ma1DXRymRps+zyKB2FJ5CL5HHBJBEG8XTQ3RU+N9sN7NEY/6SMWvxQBoYbpUbgwB7xaW FDu5x6OZrQE+RimmBc3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x79W6-0000000B7K6-2KZD; Thu, 17 Sep 2026 10:38:58 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x79W4-0000000B7Jb-3nsN; Thu, 17 Sep 2026 10:38:56 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4D40E43604; Thu, 17 Sep 2026 10:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 934A81F000FF; Thu, 17 Sep 2026 10:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789641536; bh=GgiouULxaavrRvEyeFGZnpHW8o/taKt6WxSeZJbXgG0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=WZZOmYDHsEtXapaWj6BjVYo0Egq6UJf0CFI9XwUTH/0eYaTz4mTdcF2MbSXQGd35U os/YSIJxati+HoBjFScUoJWKlIIxg62pWo1ux3sIdGM9TGBeZfAk9XUSop0SjFmMj8 HZqMSbAXCdDy5rCvHnJxyFpHEk1xVMKfU55F7chtZ35w0jjJFIYgwEHb/jQ7/EP7n5 obNutBYZxKY7GJG11PIC7YaEHuvjjyIflrt8nrHxQ/OQH14964wmRYaCbFgEckUnWl GBzHV6xw+JI5nrWC5vVf1U91z7fqSPN1np3uwU6z5QUXiq6AEUaiVqO9ZBvAgP4JnF MvwXFE+Ha9CFw== From: sashiko-bot@kernel.org Subject: Re: [PATCH] mtd: rawnand: atmel: Fix HSMC clock leak in legacy controller init To: "Wentao Liang" , alexandre.belloni@bootlin.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, vigneshr@ti.com, claudiu.beznea@tuxon.dev, stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@microchip.com, bbrezillon@kernel.org, miquel.raynal@bootlin.com, richard@nod.at In-Reply-To: <20260917102804.2146887-1-vulab@iscas.ac.cn> References: <20260917102804.2146887-1-vulab@iscas.ac.cn> Date: Thu, 17 Sep 2026 10:38:55 +0000 Message-Id: <20260917103855.934A81F000FF@smtp.kernel.org> X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gbXRkOiBiYWNrd2FyZCBn b3RvIGluIGVycm9yIGhhbmRsaW5nIHBhdGggdmlvbGF0ZXMga2VybmVsIHN0eWxlCi0tCgpjb21t aXQgYWFkOTZlYzQ4ZjliMjcwNTk4ODExZjQwNjU4MjZjNzBmMzc4Njg3YwpBdXRob3I6IFdlbnRh byBMaWFuZyA8dnVsYWJAaXNjYXMuYWMuY24+CgptdGQ6IHJhd25hbmQ6IGF0bWVsOiBGaXggSFNN QyBjbG9jayBsZWFrIGluIGxlZ2FjeSBjb250cm9sbGVyIGluaXQKCmF0bWVsX2hzbWNfbmFuZF9j b250cm9sbGVyX2xlZ2FjeV9pbml0KCkgdGFrZXMgYSByZWZlcmVuY2UgdG8gdGhlCkhTTUMgY2xv Y2sgd2l0aCBvZl9jbGtfZ2V0KCkgYW5kIGVuYWJsZXMgaXQsIGJ1dCB0aGUgZXJyb3IgcGF0aHMK dGhhdCBmb2xsb3cgb25seSByZWxlYXNlIHRoZSBkZXZpY2Ugbm9kZSwgc28gYm90aCB0aGUgcmVm ZXJlbmNlIGFuZAp0aGUgZW5hYmxlIGFyZSBsZWFrZWQgd2hlbmV2ZXIgdGhlIGNvbnRyb2xsZXIg Y2Fubm90IGJlIGZ1bGx5CmluaXRpYWxpemVkLiBBZGQgYW4gZXJyX2Rpc2FibGVfY2xrIHBhdGgg dGhhdCBkaXNhYmxlcyBhbmQgcmVsZWFzZXMKdGhlIGNsb2NrIGJlZm9yZSBqdW1waW5nIHRvIHRo ZSBleGlzdGluZyBvdXQgcGF0aC4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3 L2F0bWVsL25hbmQtY29udHJvbGxlci5jIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvYXRtZWwvbmFu ZC1jb250cm9sbGVyLmMKPiBpbmRleCA4YTE5NDA4YWJiNjM1Li5iYWZjOGM5OTVlMzc2IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L2F0bWVsL25hbmQtY29udHJvbGxlci5jCj4g KysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvYXRtZWwvbmFuZC1jb250cm9sbGVyLmMKWyAuLi4g XQo+IEBAIC0yMjYwLDYgKzIyNjEsMTIgQEAgYXRtZWxfaHNtY19uYW5kX2NvbnRyb2xsZXJfbGVn YWN5X2luaXQoc3RydWN0IGF0bWVsX2hzbWNfbmFuZF9jb250cm9sbGVyICpuYykKPiAgCW9mX25v ZGVfcHV0KG5mY19ucCk7Cj4gIAo+ICAJcmV0dXJuIHJldDsKPiArCj4gK2Vycl9kaXNhYmxlX2Ns azoKPiArCWNsa19kaXNhYmxlX3VucHJlcGFyZShuYy0+Y2xrKTsKPiArCWNsa19wdXQobmMtPmNs ayk7Cj4gKwo+ICsJZ290byBvdXQ7CgpbU2V2ZXJpdHk6IExvd10KRG9lcyB0aGlzIGJhY2t3YXJk IGp1bXAgdG8gdGhlIG91dCBsYWJlbCBpbnRyb2R1Y2UgYSByZWdyZXNzaW9uIGluIHN0YW5kYXJk Cmtlcm5lbCBjb252ZW50aW9ucyBmb3IgZXJyb3IgaGFuZGxpbmc/CgpXaGlsZSBmdW5jdGlvbmFs bHkgY29ycmVjdCwganVtcGluZyBiYWNrd2FyZHMgaW5zdGVhZCBvZiBzdHJ1Y3R1cmluZyBjYXNj YWRpbmcKZXJyb3IgbGFiZWxzIHNvIHRoYXQgdGhlIHN1Y2Nlc3MgcGF0aCBleGl0cyBvciBqdW1w cyBmb3J3YXJkIG92ZXIgdGhlIGVycm9yCmhhbmRsaW5nIGJsb2NrcyBpbnRyb2R1Y2VzIG5vbi1z dGFuZGFyZCBjb250cm9sIGZsb3cgaW4gdGhpcyBmdW5jdGlvbi4KCi0tIApTYXNoaWtvIEFJIHJl dmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA5MTcxMDI4MDQuMjE0 Njg4Ny0xLXZ1bGFiQGlzY2FzLmFjLmNuP3BhcnQ9MQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxp bmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98141C982D0 for ; Thu, 17 Sep 2026 10:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:MIME-Version:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GgiouULxaavrRvEyeFGZnpHW8o/taKt6WxSeZJbXgG0=; b=CrenFYmpfxHjhED+Oy7D0hZqNq ZXNsaryJQ9lkssPumdWQ3C36F9qzkupNrInDLKlAlzJLtA4jRJC1LmEquOCwx4VFDauESjRIEml13 GKvCh3zD4E8oWgCRtKmmRpQbFLcUt4K4iikIErDocc6uhSIQSmpUmDHtKOacSzSZvnaSUngQMdd7+ Bc2i76MZ7Zo6blK5aPTYbJtCTq0PzYXx1nnZo2MYXzMj3lIs4GzUxpJ+xMGT12YfoGwMN7BV7nWVW AEOex7wjufpHzVLr6fbU/XYA8+o+ljL18HqyV8+d8ujc2bkWxnneln3W4+VMRIPv/7Jzqyv5U5x3i 2a0/Xz2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x79W6-0000000B7Jo-1ivW; Thu, 17 Sep 2026 10:38:58 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x79W4-0000000B7Jb-3nsN; Thu, 17 Sep 2026 10:38:56 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4D40E43604; Thu, 17 Sep 2026 10:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 934A81F000FF; Thu, 17 Sep 2026 10:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789641536; bh=GgiouULxaavrRvEyeFGZnpHW8o/taKt6WxSeZJbXgG0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=WZZOmYDHsEtXapaWj6BjVYo0Egq6UJf0CFI9XwUTH/0eYaTz4mTdcF2MbSXQGd35U os/YSIJxati+HoBjFScUoJWKlIIxg62pWo1ux3sIdGM9TGBeZfAk9XUSop0SjFmMj8 HZqMSbAXCdDy5rCvHnJxyFpHEk1xVMKfU55F7chtZ35w0jjJFIYgwEHb/jQ7/EP7n5 obNutBYZxKY7GJG11PIC7YaEHuvjjyIflrt8nrHxQ/OQH14964wmRYaCbFgEckUnWl GBzHV6xw+JI5nrWC5vVf1U91z7fqSPN1np3uwU6z5QUXiq6AEUaiVqO9ZBvAgP4JnF MvwXFE+Ha9CFw== From: sashiko-bot@kernel.org Subject: Re: [PATCH] mtd: rawnand: atmel: Fix HSMC clock leak in legacy controller init To: "Wentao Liang" , alexandre.belloni@bootlin.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, vigneshr@ti.com, claudiu.beznea@tuxon.dev, stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@microchip.com, bbrezillon@kernel.org, miquel.raynal@bootlin.com, richard@nod.at In-Reply-To: <20260917102804.2146887-1-vulab@iscas.ac.cn> References: <20260917102804.2146887-1-vulab@iscas.ac.cn> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Sep 2026 10:38:55 +0000 Message-Id: <20260917103855.934A81F000FF@smtp.kernel.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] mtd: backward goto in error handling path violates kernel style -- commit aad96ec48f9b270598811f4065826c70f378687c Author: Wentao Liang mtd: rawnand: atmel: Fix HSMC clock leak in legacy controller init atmel_hsmc_nand_controller_legacy_init() takes a reference to the HSMC clock with of_clk_get() and enables it, but the error paths that follow only release the device node, so both the reference and the enable are leaked whenever the controller cannot be fully initialized. Add an err_disable_clk path that disables and releases the clock before jumping to the existing out path. > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/n= and/raw/atmel/nand-controller.c > index 8a19408abb635..bafc8c995e376 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c [ ... ] > @@ -2260,6 +2261,12 @@ atmel_hsmc_nand_controller_legacy_init(struct atme= l_hsmc_nand_controller *nc) > of_node_put(nfc_np); > =20 > return ret; > + > +err_disable_clk: > + clk_disable_unprepare(nc->clk); > + clk_put(nc->clk); > + > + goto out; [Severity: Low] Does this backward jump to the out label introduce a regression in standard kernel conventions for error handling? While functionally correct, jumping backwards instead of structuring cascad= ing error labels so that the success path exits or jumps forward over the error handling blocks introduces non-standard control flow in this function. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260917102804.2146= 887-1-vulab@iscas.ac.cn?part=3D1