From: sashiko-bot@kernel.org
To: "Daniel Matyas" <matyasdaniel006@gmail.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: axis-fifo: Added missing binding
Date: Thu, 17 Sep 2026 11:57:19 +0000 [thread overview]
Message-ID: <20260917115720.6241C1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917115023.292302-1-matyasdaniel006@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incomplete conversion leaves duplicate axis-fifo.txt binding
--
commit bd0783167655dd6947a5e11b72d707f5aebf50b9
Author: Daniel Matyas <matyasdaniel005@gmail.com>
dt-bindings: axis-fifo: Added missing binding
The commit converts the drivers/staging/axis-fifo/axis-fifo.txt binding
to a YAML schema file. The new YAML schema is created, but the original
text binding file is not deleted.
> diff --git a/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
> new file mode 100644
> index 0000000000000..e1b46a2a4b4b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/axis-fifo/xlnx,axi-fifo-mm-s.yaml
[Severity: Low]
Does this conversion patch miss the removal of the original text file?
The commit message states the intent to convert the
drivers/staging/axis-fifo/axis-fifo.txt file to a .yaml file.
However, the patch only adds the new YAML file without removing the old
.txt file.
Should the original axis-fifo.txt file be removed to complete the
conversion and avoid duplicate documentation?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917115023.292302-1-matyasdaniel006@gmail.com?part=1
next prev parent reply other threads:[~2026-09-17 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 11:48 [PATCH v2] dt-bindings: axis-fifo: Added missing binding Daniel Matyas
2026-09-17 11:57 ` sashiko-bot [this message]
2026-09-17 11:58 ` Greg Kroah-Hartman
2026-09-17 15:09 ` Daniel Matyas
2026-09-17 18:24 ` Krzysztof Kozlowski
2026-09-17 19:11 ` Daniel Matyas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917115720.6241C1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=matyasdaniel006@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.