Re: [PATCH v2 1/2] dt-bindings: rtc: Add property for Raspberry Pi 5 RTC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: invalid $ref to non-existent property charging-voltage-millivolt
- [Medium] dt-bindings: undeclared property trickle-charge-millivolt in example
--

commit 387f082415e97ddf81bc4779459443584085928f
Author: Sander Speetjens <sander.speetjens@gmail.com>

dt-bindings: rtc: Add property for Raspberry Pi 5 RTC

This commit adds a new property to configure the charging voltage for the
Raspberry Pi 5 RTC within the bcm2835-firmware binding.

> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> index 983ea80eaec97..1a0432510beeb 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> @@ -133,6 +133,11 @@ properties:
>      required:
>        - compatible
>  
> +  charging-voltage-millivolt:
> +    $ref: /schemas/rtc/rtc.yaml#/properties/charging-voltage-millivolt

[Severity: Medium]
Does the standard rtc.yaml define charging-voltage-millivolt?

Looking at the standard RTC binding (rtc.yaml), it does not define this
property. The correct standard name appears to be trickle-voltage-millivolt.
This invalid schema reference will cause make dt_binding_check to fail to
resolve the path and import constraints, breaking schema validation.

> +    minimum: 1300
> +    maximum: 5000
> +
>  required:
>    - compatible

[ ... ]

> @@ -171,5 +176,7 @@ examples:
>              touchscreen-size-x = <800>;
>              touchscreen-size-y = <480>;
>          };
> +
> +        trickle-charge-millivolt = <3300>;

[Severity: Medium]
Should this example property name match the one declared above?

The patch defines charging-voltage-millivolt in the properties block, but
the example uses trickle-charge-millivolt. Because additional properties are
restricted by the schema rules, the use of an undeclared property in the
example will trigger a strict validation failure during make dt_binding_check.

>      };
>  ...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917122144.703221-1-sander.speetjens@gmail.com?part=1