From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: xilinx-xdma: Fix device node reference leak in xilinx_pl_dma_pcie_init_irq_domain()
Date: Thu, 17 Sep 2026 13:31:19 +0000 [thread overview]
Message-ID: <20260917133119.8ECB41F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917132459.2153240-1-vulab@iscas.ac.cn>
> xilinx_pl_dma_pcie_init_irq_domain() takes a reference to the PCIe
> interrupt-controller child node with of_get_child_by_name(), but the
> error paths after the two irq_domain_create_linear() calls and after
> xilinx_pl_dma_pcie_init_msi_irq_domain() returns directly without
> dropping it. irq_domain_create_linear() gets its own reference on the
> fwnode, so the domains do not consume the caller's one.
>
> Add an err_put_node label that drops the reference before returning.
>
> Fixes: 8d786149d78c ("PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917132459.2153240-1-vulab@iscas.ac.cn?part=1
prev parent reply other threads:[~2026-09-17 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 13:24 [PATCH] PCI: xilinx-xdma: Fix device node reference leak in xilinx_pl_dma_pcie_init_irq_domain() Wentao Liang
2026-09-17 13:31 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917133119.8ECB41F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.