From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/IOV: Fix peer device reference leak in sriov_init()
Date: Thu, 17 Sep 2026 13:33:23 +0000 [thread overview]
Message-ID: <20260917133323.D24E11F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917132745.2153341-1-vulab@iscas.ac.cn>
> sriov_init() takes a reference to the SR-IOV physical function device
> with pci_dev_get() and stores it in iov->dev. If the subsequent
> compute_max_vf_buses() call fails, the fail_max_buses path frees iov
> without dropping that reference, unlike sriov_release() which puts
> iov->dev on the normal teardown path.
>
> Drop the reference on the fail_max_buses path as well.
>
> Fixes: ea9a8854161d ("PCI: Set SR-IOV NumVFs to zero after enumeration")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917132745.2153341-1-vulab@iscas.ac.cn?part=1
prev parent reply other threads:[~2026-09-17 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 13:27 [PATCH] PCI/IOV: Fix peer device reference leak in sriov_init() Wentao Liang
2026-09-17 13:33 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917133323.D24E11F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.