Re: [PATCH v4 3/5] iio: imu: inv_icm42607: Add support for ICM-42370-P

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] iio: inv_icm42607: writing reserved values to gyro registers on accel-only device
--

commit cafef20bbc68d8f84bfd67491344163a59e13b31
Author: Kanak Shilledar <kanak.shilledar@axis.com>

iio: imu: inv_icm42607: Add support for ICM-42370-P

Add support for the Invensense ICM-42370-P MEMS MotionTracking 3-axis
accelerometer with built-in temperature sensor. This device is almost
identical to the existing Invensense ICM-42607-P IMU, but lacks
gyroscope.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> index 190e998f7b8ef..114e7afcda391 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> @@ -92,10 +92,27 @@ static const struct inv_icm42607_conf inv_icm42607_default_conf = {
>  	},
>  };
>  
> +static const struct inv_icm42607_conf inv_icm42370_default_conf = {
> +	.accel = {
> +		.mode = INV_ICM42607_SENSOR_MODE_OFF,
> +		.fs = INV_ICM42607_ACCEL_FS_4G,
> +		.odr = INV_ICM42607_ODR_100HZ,
> +		.filter = INV_ICM42607_FILTER_BW_25HZ,
> +	},
> +};

[Severity: Medium]
Does this uninitialized gyro configuration write reserved values to the device?

Because the gyro field is not initialized, its subfields default to 0.

During probe, inv_icm42607_setup() calls inv_icm42607_set_init_conf(),
which unconditionally writes the gyro configuration without checking
st->hw->has_gyro:

drivers/iio/imu/inv_icm42607/inv_icm42607_core.c:inv_icm42607_set_init_conf() {
    ...
    val = FIELD_PREP(INV_ICM42607_GYRO_CONFIG0_FS_SEL_MASK, conf->gyro.fs);
    val |= FIELD_PREP(INV_ICM42607_GYRO_CONFIG0_ODR_MASK, conf->gyro.odr);
    ret = regmap_write(st->map, INV_ICM42607_REG_GYRO_CONFIG0, val);
    ...
}

Writing 0 to the ODR field (which is reserved for values 0-4) could cause
hardware faults or undefined behavior.

Could we add a has_gyro check in inv_icm42607_set_init_conf() or initialize
the gyro field properly to avoid this regression?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-b4-inv_icm42370p-v4-0-fd9373f123c9@axis.com?part=3