From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51BD4576EB4 for ; Thu, 17 Sep 2026 14:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789653727; cv=none; b=h6I4JbJdiemIzGako71MKJDj+M1+3R24P9s/WyNWtMcaEBlEpgGfwmmcmrYMcJiJpcAC1/Md+D37LEPAzyGn+/clDX8fWPZ3k/GYtPKJ7+EbKUNzooLcmOX3WqtVzdwOm9dhtzGxslSgdS+idDJjQnMnY8heVtADoSeNm+wV480= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789653727; c=relaxed/simple; bh=RKbxvG3X7OjHQiTsXn8FcSsjYMNYPvJhLdzCNnf+diE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z9EiaBYOAwj3Qtzf4CCGhvrLHbA5BAh06bCtvI4tc8NN4MG5WmyrxK1rIvnAKzuQ0r8L12DMDmtRamp7aq+2Qtzh3CB+RwkmB2SpSYdRdsnW8buhSvsjTzekc0pq5VwdZIis7sK5VmCj6GzP0D6uGDHrHi2O75FKflf4hZagKtA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=no3Q+phE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="no3Q+phE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C08F1F00893; Thu, 17 Sep 2026 14:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789653724; bh=qolMCHgXvdmeJqyN0ZcfNa7GBMeqIELSFMO1ziMW6gQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=no3Q+phE0NgKCzxqXefrxsxmkgzDJ6hDucGtl6VsEXO2b45thXHaT96odsZuEk2fd 8HjZD9V5xTF0Qa1NKl0rTym424sSYVD/LWjnwneZrpBOqNGgWrLzO0Pc9JG1UkqesJ vpCLGBAFh6PxFrnNUrIL9iB9QAHkezsivpvnSJV9qS4PQx/Q7GPNGWHyKfV4Y6VTaF /SY/mUsjd2Wpn3d0TwxK3K19HOTUhLbPEWMuHX1KPHRYF4aZTYwlG1DFEu35cU8myY aJDqD5vsvfCCZyJbRn9PXRrj1z+VR+tKuaYJGcxYTVoa6vwhW7WI/FzBDHiU4tXVvk lXWu73EYF5HlQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Paulo Alcantara , Namjae Jeon , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Sasha Levin Subject: [PATCH 6.6.y 3/3] smb: client: fix WSL reparse point uid/gid override Date: Thu, 17 Sep 2026 10:01:58 -0400 Message-ID: <20260917140158.504356-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260917140158.504356-1-sashal@kernel.org> References: <2026091653-repaying-rockslide-b109@gregkh> <20260917140158.504356-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Paulo Alcantara [ Upstream commit cd2b2b57921d4caa7875e83198bb2aa71254328b ] wsl_to_fattr() unconditionally overwrites cf_uid/cf_gid with values from WSL extended attributes ($LXUID/$LXGID), ignoring the forceuid and forcegid mount options. Fix this by initializing cf_uid/cf_gid to the mount defaults and gating the $LXUID/$LXGID EA parsing on forceuid/forcegid. Closes: https://sashiko.dev/#/patchset/20260906190803.667489-1-pc%40manguebit.org Reviewed-by: Namjae Jeon Signed-off-by: Paulo Alcantara Cc: Ronnie Sahlberg Cc: Shyam Prasad N Cc: Tom Talpey Cc: Bharath SM Cc: stable@vger.kernel.org Signed-off-by: Sasha Levin --- fs/smb/client/reparse.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c index 4d45c31336df1..fd406f77053fb 100644 --- a/fs/smb/client/reparse.c +++ b/fs/smb/client/reparse.c @@ -678,10 +678,14 @@ static bool wsl_to_fattr(struct cifs_open_info_data *data, struct cifs_sb_info *cifs_sb, u32 tag, struct cifs_fattr *fattr) { + unsigned int sbflags = cifs_sb_flags(cifs_sb); struct smb2_file_full_ea_info *ea; bool have_xattr_dev = false; u32 next = 0; + fattr->cf_uid = cifs_sb->ctx->linux_uid; + fattr->cf_gid = cifs_sb->ctx->linux_gid; + switch (tag) { case IO_REPARSE_TAG_LX_SYMLINK: fattr->cf_mode |= S_IFLNK; @@ -718,11 +722,13 @@ static bool wsl_to_fattr(struct cifs_open_info_data *data, nlen = ea->ea_name_length; v = (void *)((u8 *)ea->ea_data + ea->ea_name_length + 1); - if (!strncmp(name, SMB2_WSL_XATTR_UID, nlen)) - fattr->cf_uid = wsl_make_kuid(cifs_sb, v); - else if (!strncmp(name, SMB2_WSL_XATTR_GID, nlen)) - fattr->cf_gid = wsl_make_kgid(cifs_sb, v); - else if (!strncmp(name, SMB2_WSL_XATTR_MODE, nlen)) { + if (!strncmp(name, SMB2_WSL_XATTR_UID, nlen)) { + if (!(sbflags & CIFS_MOUNT_OVERR_UID)) + fattr->cf_uid = wsl_make_kuid(cifs_sb, v); + } else if (!strncmp(name, SMB2_WSL_XATTR_GID, nlen)) { + if (!(sbflags & CIFS_MOUNT_OVERR_GID)) + fattr->cf_gid = wsl_make_kgid(cifs_sb, v); + } else if (!strncmp(name, SMB2_WSL_XATTR_MODE, nlen)) { /* File type in reparse point tag and in xattr mode must match. */ if (S_DT(fattr->cf_mode) != S_DT(le32_to_cpu(*(__le32 *)v))) return false; -- 2.53.0